feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove dangling PropertyChanges and KeyFrameGroups

Browse Source 
This removes dangling PropertyChanges and KeyFrameGroups when removing
a dynamic property.

Change-Id: I333b6a61bec34a0bcde1d19372166b3cfaea195b
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This commit is contained in:
Thomas Hartmann
2022-09-14 16:18:07 +02:00
parent 696b02ee28
commit 3ce5af7a79
1 changed files with 29 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/plugins/qmldesigner/components/connectioneditor/dynamicpropertiesmodel.cpp
View File

@@ -458,16 +458,35 @@ QStringList DynamicPropertiesModel::possibleSourceProperties(const BindingProper
void DynamicPropertiesModel::deleteDynamicPropertyByRow(int rowNumber) void DynamicPropertiesModel::deleteDynamicPropertyByRow(int rowNumber)
{ {
m_view->executeInTransaction("DynamicPropertiesModel::deleteDynamicPropertyByRow", [this, rowNumber]() { m_view->executeInTransaction(
BindingProperty bindingProperty = bindingPropertyForRow(rowNumber); "DynamicPropertiesModel::deleteDynamicPropertyByRow", [this, rowNumber]() {
if (bindingProperty.isValid()) { const AbstractProperty property = abstractPropertyForRow(rowNumber);
bindingProperty.parentModelNode().removeProperty(bindingProperty.name()); const PropertyName propertyName = property.name();
} else { BindingProperty bindingProperty = bindingPropertyForRow(rowNumber);
VariantProperty variantProperty = variantPropertyForRow(rowNumber); if (bindingProperty.isValid()) {
if (variantProperty.isValid()) bindingProperty.parentModelNode().removeProperty(bindingProperty.name());
variantProperty.parentModelNode().removeProperty(variantProperty.name()); } else {
} VariantProperty variantProperty = variantPropertyForRow(rowNumber);
}); if (variantProperty.isValid())
variantProperty.parentModelNode().removeProperty(variantProperty.name());
}
if (property.isValid()) {
QmlObjectNode objectNode = QmlObjectNode(property.parentModelNode());
const auto stateOperations = objectNode.allAffectingStatesOperations();
for (const QmlModelStateOperation &stateOperation : stateOperations) {
if (stateOperation.modelNode().hasProperty(propertyName))
stateOperation.modelNode().removeProperty(propertyName);
}
const auto timelineNodes = objectNode.allTimelines();
for (auto &timelineNode : timelineNodes) {
QmlTimeline timeline(timelineNode);
timeline.removeKeyframesForTargetAndProperty(objectNode.modelNode(),
propertyName);
}
}
});
resetModel(); resetModel();
} }