From 3cfa1902c6173c951add5884d4371b88e99ee3bf Mon Sep 17 00:00:00 2001 From: David Schulz Date: Thu, 29 Jun 2023 09:22:58 +0200 Subject: [PATCH] AutoTest: simplify TestVisitor::visit Change-Id: I26e8eb8788da80afbfbd266f01828b860fc0622a Reviewed-by: Christian Stenger --- src/plugins/autotest/qtest/qttestvisitors.cpp | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/plugins/autotest/qtest/qttestvisitors.cpp b/src/plugins/autotest/qtest/qttestvisitors.cpp index 6f615c99321..318691db94f 100644 --- a/src/plugins/autotest/qtest/qttestvisitors.cpp +++ b/src/plugins/autotest/qtest/qttestvisitors.cpp @@ -51,17 +51,11 @@ bool TestVisitor::visit(Class *symbol) Function *functionDefinition = m_symbolFinder.findMatchingDefinition( func, m_snapshot, true); - if (functionDefinition && functionDefinition->fileId()) { - locationAndType.m_filePath = FilePath::fromString( - QString::fromUtf8(functionDefinition->fileName())); - locationAndType.m_line = functionDefinition->line(); - locationAndType.m_column = functionDefinition->column() - 1; - } else { // if we cannot find the definition use declaration as fallback - locationAndType.m_filePath = FilePath::fromString( - QString::fromUtf8(member->fileName())); - locationAndType.m_line = member->line(); - locationAndType.m_column = member->column() - 1; - } + if (functionDefinition && functionDefinition->fileId()) + member = functionDefinition; + locationAndType.m_filePath = FilePath::fromUtf8(member->fileName()); + locationAndType.m_line = member->line(); + locationAndType.m_column = member->column() - 1; if (specialFunctions.contains(name)) locationAndType.m_type = TestTreeItem::TestSpecialFunction; else if (name.endsWith("_data"))