feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify BuildStepWidget updating

Browse Source 
Change-Id: I189ca0aa3b88227feae881df026f8578079e1c55
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-10-06 16:02:24 +02:00
parent 45ca2e2924
commit 3d308d7195
2 changed files with 7 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/plugins/projectexplorer/buildstepspage.cpp
View File

@@ -224,32 +224,6 @@ BuildStepListWidget::~BuildStepListWidget()
m_buildStepsData.clear(); m_buildStepsData.clear();
} }
void BuildStepListWidget::updateSummary()
{
auto step = qobject_cast<BuildStep *>(sender());
if (step) {
foreach (const BuildStepsWidgetData *s, m_buildStepsData) {
if (s->step == step) {
s->detailsWidget->setSummaryText(step->summaryText());
break;
}
}
}
}
void BuildStepListWidget::updateEnabledState()
{
auto step = qobject_cast<BuildStep *>(sender());
if (step) {
foreach (const BuildStepsWidgetData *s, m_buildStepsData) {
if (s->step == step) {
s->toolWidget->setBuildStepEnabled(step->enabled());
break;
}
}
}
}
void BuildStepListWidget::updateAddBuildStepMenu() void BuildStepListWidget::updateAddBuildStepMenu()
{ {
QMenu *menu = m_addButton->menu(); QMenu *menu = m_addButton->menu();
@@ -285,11 +259,14 @@ void BuildStepListWidget::addBuildStep(int pos)
m_vbox->insertWidget(pos, s->detailsWidget); m_vbox->insertWidget(pos, s->detailsWidget);
connect(s->step, &BuildStep::updateSummary, connect(s->step, &BuildStep::updateSummary, this, [s] {
this, &BuildStepListWidget::updateSummary); s->detailsWidget->setSummaryText(s->step->summaryText());
});
connect(s->step, &BuildStep::enabledChanged, this, [s] {
s->toolWidget->setBuildStepEnabled(s->step->enabled());
});
connect(s->step, &BuildStep::enabledChanged,
this, &BuildStepListWidget::updateEnabledState);
// Expand new build steps by default // Expand new build steps by default
const bool expand = newStep->hasUserExpansionState() const bool expand = newStep->hasUserExpansionState()

2
src/plugins/projectexplorer/buildstepspage.h
View File

@@ -98,8 +98,6 @@ public:
private: private:
void updateAddBuildStepMenu(); void updateAddBuildStepMenu();
void addBuildStep(int pos); void addBuildStep(int pos);
void updateSummary();
void updateEnabledState();
void stepMoved(int from, int to); void stepMoved(int from, int to);
void removeBuildStep(int pos); void removeBuildStep(int pos);