feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Prefer using 'override' instead of 'virtual'

Browse Source 
warning: prefer using 'override' or (rarely) 'final' instead of
'virtual' [modernize-use-override]

Change-Id: I6dac7a62b627fa1353b4455e1af92f869c2571cc
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
This commit is contained in:
Alessandro Portale
2018-07-11 07:31:38 +02:00
parent 3c8dec2398
commit 3d3f14e3fe
32 changed files with 242 additions and 242 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
src/libs/cplusplus/CppRewriter.cpp
View File

@@ -73,52 +73,52 @@ public:
return (!temps.isEmpty()) ? temps.takeLast() : ty;
}
virtual void visit(UndefinedType *)
void visit(UndefinedType *) override
{
temps.append(FullySpecifiedType());
}
virtual void visit(VoidType *)
void visit(VoidType *) override
{
temps.append(control()->voidType());
}
virtual void visit(IntegerType *type)
void visit(IntegerType *type) override
{
temps.append(control()->integerType(type->kind()));
}
virtual void visit(FloatType *type)
void visit(FloatType *type) override
{
temps.append(control()->floatType(type->kind()));
}
virtual void visit(PointerToMemberType *type)
void visit(PointerToMemberType *type) override
{
const Name *memberName = rewrite->rewriteName(type->memberName());
const FullySpecifiedType elementType = rewrite->rewriteType(type->elementType());
temps.append(control()->pointerToMemberType(memberName, elementType));
}
virtual void visit(PointerType *type)
void visit(PointerType *type) override
{
const FullySpecifiedType elementType = rewrite->rewriteType(type->elementType());
temps.append(control()->pointerType(elementType));
}
virtual void visit(ReferenceType *type)
void visit(ReferenceType *type) override
{
const FullySpecifiedType elementType = rewrite->rewriteType(type->elementType());
temps.append(control()->referenceType(elementType, type->isRvalueReference()));
}
virtual void visit(ArrayType *type)
void visit(ArrayType *type) override
{
const FullySpecifiedType elementType = rewrite->rewriteType(type->elementType());
temps.append(control()->arrayType(elementType, type->size()));
}
virtual void visit(NamedType *type)
void visit(NamedType *type) override
{
FullySpecifiedType ty = rewrite->env->apply(type->name(), rewrite);
if (! ty->isUndefinedType()) {
@@ -129,7 +129,7 @@ public:
}
}
virtual void visit(Function *type)
void visit(Function *type) override
{
Function *funTy = control()->newFunction(0, 0);
funTy->copy(type);
@@ -158,55 +158,55 @@ public:
temps.append(funTy);
}
virtual void visit(Namespace *type)
void visit(Namespace *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(Class *type)
void visit(Class *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(Enum *type)
void visit(Enum *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(ForwardClassDeclaration *type)
void visit(ForwardClassDeclaration *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(ObjCClass *type)
void visit(ObjCClass *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(ObjCProtocol *type)
void visit(ObjCProtocol *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(ObjCMethod *type)
void visit(ObjCMethod *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(ObjCForwardClassDeclaration *type)
void visit(ObjCForwardClassDeclaration *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
}
virtual void visit(ObjCForwardProtocolDeclaration *type)
void visit(ObjCForwardProtocolDeclaration *type) override
{
qWarning() << Q_FUNC_INFO;
temps.append(type);
@@ -242,19 +242,19 @@ public:
return (!temps.isEmpty()) ? temps.takeLast() : name;
}
virtual void visit(const QualifiedNameId *name)
void visit(const QualifiedNameId *name) override
{
const Name *base = rewrite->rewriteName(name->base());
const Name *n = rewrite->rewriteName(name->name());
temps.append(control()->qualifiedNameId(base, n));
}
virtual void visit(const Identifier *name)
void visit(const Identifier *name) override
{
temps.append(control()->identifier(name->chars(), name->size()));
}
virtual void visit(const TemplateNameId *name)
void visit(const TemplateNameId *name) override
{
QVarLengthArray<FullySpecifiedType, 8> args(name->templateArgumentCount());
for (unsigned i = 0; i < name->templateArgumentCount(); ++i)
@@ -263,23 +263,23 @@ public:
args.data(), args.size()));
}
virtual void visit(const DestructorNameId *name)
void visit(const DestructorNameId *name) override
{
temps.append(control()->destructorNameId(identifier(name->identifier())));
}
virtual void visit(const OperatorNameId *name)
void visit(const OperatorNameId *name) override
{
temps.append(control()->operatorNameId(name->kind()));
}
virtual void visit(const ConversionNameId *name)
void visit(const ConversionNameId *name) override
{
FullySpecifiedType ty = rewrite->rewriteType(name->type());
temps.append(control()->conversionNameId(ty));
}
virtual void visit(const SelectorNameId *name)
void visit(const SelectorNameId *name) override
{
QVarLengthArray<const Name *, 8> names(name->nameCount());
for (unsigned i = 0; i < name->nameCount(); ++i)