feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Ramp down MainWindow in it's ICore::pimpl function

Browse Source 
Change-Id: I7c4934248ea4794f7d4eb95f98d19994b56fa0f1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2023-09-15 16:47:37 +02:00
parent 3705b4b609
commit 3d7cf53a1e
5 changed files with 173 additions and 294 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
src/plugins/coreplugin/icore.h
View File

@@ -11,9 +11,7 @@
#include <utils/qtcsettings.h>
#include <QList>
#include <QObject>
#include <QRect>
#include <QSettings>
#include <functional>
@@ -34,18 +32,10 @@ class IDocument;
class IWizardFactory;
class NewDialog;
namespace Internal {
class MainWindow;
class MainWindowPrivate;
} // Internal
class CORE_EXPORT ICore : public QObject
{
Q_OBJECT
friend class Internal::MainWindow;
friend class Internal::MainWindowPrivate;
public:
ICore();
~ICore() override;
@@ -115,7 +105,6 @@ public:
StopOnLoadFail = 4,
SwitchSplitIfAlreadyVisible = 8
};
static void openFiles(const Utils::FilePaths &filePaths, OpenFilesFlags flags = None);
static void addPreCloseListener(const std::function<bool()> &listener);
@@ -127,6 +116,10 @@ public:
MainWindowClosing,
};
public slots:
static void openFileWith();
static void exit();
signals:
void coreAboutToOpen();
void coreOpened();
@@ -164,56 +157,11 @@ public:
static void init();
static void extensionsInitialized();
static void aboutToShutdown();
};
namespace Internal {
class MainWindow : public Utils::AppMainWindow
{
Q_OBJECT
public:
MainWindow();
~MainWindow() override;
IContext *contextObject(QWidget *widget) const;
void addContextObject(IContext *context);
void removeContextObject(IContext *context);
static void saveSettings();
static IDocument *openFiles(const Utils::FilePaths &filePaths,
ICore::OpenFilesFlags flags,
OpenFilesFlags flags = None,
const Utils::FilePath &workingDirectory = {});
QPrinter *printer() const;
IContext *currentContextObject() const;
QStatusBar *statusBar() const;
Utils::InfoBar *infoBar() const;
void updateAdditionalContexts(const Context &remove, const Context &add,
ICore::ContextPriority priority);
QStringList additionalAboutInformation() const;
void clearAboutInformation();
void appendAboutInformation(const QString &line);
void addPreCloseListener(const std::function<bool()> &listener);
void saveSettings();
void restart();
void restartTrimmer();
public slots:
static void openFileWith();
void exit();
private:
void closeEvent(QCloseEvent *event) override;
void keyPressEvent(QKeyEvent *event) override;
void mousePressEvent(QMouseEvent *event) override;
};
} // namespace Internal
} // namespace Core