feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix crash

Browse Source 
This case should not happen and is handled in a separate patch,
but in case we miss another corner case this avoids the crash.

Task-number: QTCREATORBUG-25437
Change-Id: I370e3e0b6901d8cdd857714a0766f0f8442a3d66
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Thomas Hartmann
2021-04-06 14:02:13 +02:00
parent aaa3fda1ad
commit 3d917a01cc
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmldesigner/components/connectioneditor/connectionmodel.cpp
View File

@@ -39,6 +39,8 @@
#include <qmldesignerconstants.h> #include <qmldesignerconstants.h>
#include <qmldesignerplugin.h> #include <qmldesignerplugin.h>
#include <utils/qtcassert.h>
#include <QStandardItemModel> #include <QStandardItemModel>
#include <QMessageBox> #include <QMessageBox>
#include <QTableView> #include <QTableView>
@@ -370,7 +372,10 @@ void ConnectionModel::abstractPropertyChanged(const AbstractProperty &abstractPr
void ConnectionModel::deleteConnectionByRow(int currentRow) void ConnectionModel::deleteConnectionByRow(int currentRow)
{ {
SignalHandlerProperty targetSignal = signalHandlerPropertyForRow(currentRow); SignalHandlerProperty targetSignal = signalHandlerPropertyForRow(currentRow);
QTC_ASSERT(targetSignal.isValid(), return );
QmlDesigner::ModelNode node = targetSignal.parentModelNode(); QmlDesigner::ModelNode node = targetSignal.parentModelNode();
QTC_ASSERT(node.isValid(), return );
QList<SignalHandlerProperty> allSignals = node.signalProperties(); QList<SignalHandlerProperty> allSignals = node.signalProperties();
if (allSignals.size() > 1) { if (allSignals.size() > 1) {
if (allSignals.contains(targetSignal)) if (allSignals.contains(targetSignal))