feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJSEditorPlugin: Refactor

Browse Source 
This follows the recently introduced pattern for plugin setup
- Pimpl QmlJSEditorPlugin
- remove unneeded uses of global object pool
- apply "static pattern"
- simplify some constructors of data members in some cases
- use in-class initialization in some case

Change-Id: I95b42d0885f4a8d6c9bfe1e4c004d3ace0a3eba5
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2018-02-15 09:50:02 +01:00
parent 4786c5928a
commit 3da9c89981
11 changed files with 120 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/qmljseditor/quicktoolbar.h
View File

@@ -38,7 +38,7 @@ class QuickToolBar : public QmlJS::IContextPane
Q_OBJECT
public:
QuickToolBar(QObject *parent = 0);
QuickToolBar();
~QuickToolBar();
void apply(TextEditor::TextEditorWidget *widget, QmlJS::Document::Ptr document, const QmlJS::ScopeChain *scopeChain, QmlJS::AST::Node *node, bool update, bool force = false);
bool isAvailable(TextEditor::TextEditorWidget *widget, QmlJS::Document::Ptr document, QmlJS::AST::Node *node);
@@ -59,9 +59,9 @@ private:
QmlEditorWidgets::ContextPaneWidget* contextWidget();
QPointer<QmlEditorWidgets::ContextPaneWidget> m_widget;
QmlJS::Document::Ptr m_doc;
QmlJS::AST::Node *m_node;
TextEditor::TextEditorWidget *m_editorWidget;
bool m_blockWriting;
QmlJS::AST::Node *m_node = nullptr;
TextEditor::TextEditorWidget *m_editorWidget = nullptr;
bool m_blockWriting = false;
QStringList m_propertyOrder;
QStringList m_prototypes;
QString m_oldType;