feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FileSearch: Some micro-optimization

Browse Source 
Fixes: QTCREATORBUG-27552
Change-Id: I1b4677af59f335df676d32c2bb0e1dbd5a9dd14b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2022-05-16 13:45:00 +02:00
parent 486ec4239a
commit 3db3b441db
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libs/utils/filesearch.cpp
View File

@@ -159,8 +159,7 @@ void FileSearch::operator()(QFutureInterface<FileSearchResultList> &futureInterf
while (!stream.atEnd()) { while (!stream.atEnd()) {
++lineNr; ++lineNr;
const QString chunk = stream.readLine(); const QString chunk = stream.readLine();
const QString resultItemText = clippedText(chunk, MAX_LINE_SIZE); const int chunkLength = chunk.length();
int chunkLength = chunk.length();
const QChar *chunkPtr = chunk.constData(); const QChar *chunkPtr = chunk.constData();
const QChar *chunkEnd = chunkPtr + chunkLength - 1; const QChar *chunkEnd = chunkPtr + chunkLength - 1;
for (const QChar *regionPtr = chunkPtr; regionPtr + termMaxIndex <= chunkEnd; ++regionPtr) { for (const QChar *regionPtr = chunkPtr; regionPtr + termMaxIndex <= chunkEnd; ++regionPtr) {
@@ -207,12 +206,17 @@ void FileSearch::operator()(QFutureInterface<FileSearchResultList> &futureInterf
&& *regionCursor != termDataUpper[regionIndex]) && *regionCursor != termDataUpper[regionIndex])
) { ) {
equal = false; equal = false;
break;
} }
} }
} }
if (equal) { if (equal) {
results << FileSearchResult(item.filePath, lineNr, resultItemText, const QString resultItemText = clippedText(chunk, MAX_LINE_SIZE);
regionPtr - chunkPtr, termMaxIndex + 1, results << FileSearchResult(item.filePath,
lineNr,
resultItemText,
regionPtr - chunkPtr,
termMaxIndex + 1,
QStringList()); QStringList());
regionPtr += termMaxIndex; // another +1 done by for-loop regionPtr += termMaxIndex; // another +1 done by for-loop
} }