feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Hide plugin class definition in the .cpp

Browse Source 
It's not meant to be accessed from the outside.

Change-Id: I0652ec8309e678a9b28e05acab6d0f77a0b13639
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2024-01-12 08:51:08 +01:00
parent bffd9a39b5
commit 3e3cf3f8a4
7 changed files with 126 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/autotest/testrunner.cpp
View File

@@ -225,7 +225,7 @@ static RunConfiguration *getRunConfiguration(const QString &buildTargetKey)
return !rc->runnable().command.isEmpty();
});
const ChoicePair oldChoice = AutotestPlugin::cachedChoiceFor(buildTargetKey);
const ChoicePair oldChoice = cachedChoiceFor(buildTargetKey);
if (!oldChoice.executable.isEmpty()) {
runConfig = Utils::findOrDefault(runConfigurations,
[&oldChoice](const RunConfiguration *rc) {
@@ -251,7 +251,7 @@ static RunConfiguration *getRunConfiguration(const QString &buildTargetKey)
return rc->runnable().command.executable() == exe;
});
if (runConfig && dialog.rememberChoice())
AutotestPlugin::cacheRunConfigChoice(buildTargetKey, ChoicePair(dName, exe));
cacheRunConfigChoice(buildTargetKey, ChoicePair(dName, exe));
}
return runConfig;
}
@@ -468,7 +468,7 @@ void TestRunner::runTestsHelper()
});
if (testSettings().popupOnStart())
AutotestPlugin::popupResultsPane();
popupResultsPane();
m_taskTree->start();
}
@@ -590,7 +590,7 @@ void TestRunner::debugTests()
connect(runControl, &RunControl::stopped, this, &TestRunner::onFinished);
ProjectExplorerPlugin::startRunControl(runControl);
if (useOutputProcessor && testSettings().popupOnStart())
AutotestPlugin::popupResultsPane();
popupResultsPane();
}
static bool executablesEmpty()
@@ -672,7 +672,7 @@ static RunAfterBuildMode runAfterBuild()
if (!project->namedSettings(Constants::SK_USE_GLOBAL).isValid())
return testSettings().runAfterBuildMode();
TestProjectSettings *projectSettings = AutotestPlugin::projectSettings(project);
TestProjectSettings *projectSettings = Internal::projectSettings(project);
return projectSettings->useGlobalSettings() ? testSettings().runAfterBuildMode()
: projectSettings->runAfterBuild();
}