feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Fix converting old settings on Windows

Browse Source 
As the settings keys are case-insensitive on Windows, the condition

  s->value(oldDiagnosticConfigIdKey).isNull()

in ClangToolsSettings::readSettings always evaluated to true, leaving
inconsistent settings around (new and old).

As a result, the QTC_ASSERT parallelRuns >= 1 was triggered in
ClangToolRunWorker::start() and nothing was analyzed.

Fix by using a truly different settings key after conversion.

Change-Id: I467f7d71298f240812a56dfcf7d6ca81728dee32
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Nikolai Kosjar
2019-11-27 11:02:48 +01:00
parent 60e4c62912
commit 3e72fd9f45
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/clangtools/clangtoolssettings.h
View File

@@ -34,7 +34,7 @@
namespace ClangTools { namespace ClangTools {
namespace Internal { namespace Internal {
const char diagnosticConfigIdKey[] = "DiagnosticConfigId"; const char diagnosticConfigIdKey[] = "DiagnosticConfig";
class RunSettings class RunSettings
{ {