Terminal: Coverity warning fixes

Change-Id: If96291ff6df97f7e85840eb0951cc3f4abfab0f6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-02-27 11:06:14 +01:00
parent d4ac8aeaa6
commit 3e73fe302e
4 changed files with 9 additions and 6 deletions

View File

@@ -343,15 +343,16 @@ void ShellProcess::configChildProcess()
struct utmpx utmpxInfo;
memset(&utmpxInfo, 0, sizeof(utmpxInfo));
strncpy(utmpxInfo.ut_user, qgetenv("USER"), sizeof(utmpxInfo.ut_user));
strncpy(utmpxInfo.ut_user, qgetenv("USER"), sizeof(utmpxInfo.ut_user) - 1);
QString device(m_handleSlaveName);
if (device.startsWith("/dev/"))
device = device.mid(5);
const char *d = device.toLatin1().constData();
const auto deviceAsLatin1 = device.toLatin1();
const char *d = deviceAsLatin1.constData();
strncpy(utmpxInfo.ut_line, d, sizeof(utmpxInfo.ut_line));
strncpy(utmpxInfo.ut_line, d, sizeof(utmpxInfo.ut_line) - 1);
strncpy(utmpxInfo.ut_id, d + strlen(d) - sizeof(utmpxInfo.ut_id), sizeof(utmpxInfo.ut_id));