From 3e81fe628a5e7787ef015616754b2f3a79bceb41 Mon Sep 17 00:00:00 2001
From: Christian Stenger <christian.stenger@qt.io>
Date: Mon, 22 Jan 2018 12:23:09 +0100
Subject: [PATCH] QmlJSEditor: Avoid detaching of containers

Change-Id: I52bb5b073793c11cf157cb72244ba3552ca1ac72
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
---
 src/plugins/qmljseditor/qmljseditordocument.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/plugins/qmljseditor/qmljseditordocument.cpp b/src/plugins/qmljseditor/qmljseditordocument.cpp
index 79c348ecc4d..66fa6da393e 100644
--- a/src/plugins/qmljseditor/qmljseditordocument.cpp
+++ b/src/plugins/qmljseditor/qmljseditordocument.cpp
@@ -43,6 +43,8 @@
 #include <qmljstools/qmljsmodelmanager.h>
 #include <qmljstools/qmljsqtstylecodeformatter.h>
 
+#include <utils/asconst.h>
+
 using namespace QmlJSEditor;
 using namespace QmlJS;
 using namespace QmlJS::AST;
@@ -625,13 +627,13 @@ void QmlJSEditorDocumentPrivate::createTextMarks(const SemanticInfo &info)
         m_semanticMarks.removeAll(mark);
         delete mark;
     };
-    for (const DiagnosticMessage &diagnostic : info.semanticMessages) {
+    for (const DiagnosticMessage &diagnostic : Utils::asConst(info.semanticMessages)) {
         auto mark = new QmlJSTextMark(q->filePath().toString(),
                                       diagnostic, onMarkRemoved);
         m_semanticMarks.append(mark);
         q->addMark(mark);
     }
-    for (const QmlJS::StaticAnalysis::Message &message : info.staticAnalysisMessages) {
+    for (const QmlJS::StaticAnalysis::Message &message : Utils::asConst(info.staticAnalysisMessages)) {
         auto mark = new QmlJSTextMark(q->filePath().toString(),
                                       message, onMarkRemoved);
         m_semanticMarks.append(mark);