feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Make member functions const/static

Browse Source 
readability-make-member-function-const finds lots of member functions
that could be made const. This change just picks getter functions that
really should be const.

readability-convert-member-functions-to-static finds non-static member
functions which do not access this. This change turns most of them
into static ones, but leaves some non static to keep the class API
consistent.

Change-Id: I004d6f7fab4375f9902f940f29b4a4f561fc7604
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Alessandro Portale
2020-12-10 00:59:50 +01:00
parent a40e5b5382
commit 3e9385bf1b
45 changed files with 84 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/coreplugin/find/findplugin.cpp
View File

@@ -182,7 +182,8 @@ public:
bool isAnyFilterEnabled() const;
void writeSettings();
void setFindFlag(Core::FindFlag flag, bool enabled);
void updateCompletion(const QString &text, QStringList &completions, QStringListModel *model);
static void updateCompletion(const QString &text, QStringList &completions,
QStringListModel *model);
void setupMenu();
void setupFilterMenuItems();
void readSettings();
@@ -429,7 +430,7 @@ void Find::updateFindCompletion(const QString &text, FindFlags flags)
void Find::updateReplaceCompletion(const QString &text)
{
d->updateCompletion(text, d->m_replaceCompletions, &d->m_replaceCompletionModel);
FindPrivate::updateCompletion(text, d->m_replaceCompletions, &d->m_replaceCompletionModel);
}
void FindPrivate::updateCompletion(const QString &text, QStringList &completions, QStringListModel *model)