feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Make member functions const/static

Browse Source 
readability-make-member-function-const finds lots of member functions
that could be made const. This change just picks getter functions that
really should be const.

readability-convert-member-functions-to-static finds non-static member
functions which do not access this. This change turns most of them
into static ones, but leaves some non static to keep the class API
consistent.

Change-Id: I004d6f7fab4375f9902f940f29b4a4f561fc7604
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Alessandro Portale
2020-12-10 00:59:50 +01:00
parent a40e5b5382
commit 3e9385bf1b
45 changed files with 84 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/coreplugin/iwizardfactory.cpp
View File

@@ -227,7 +227,7 @@ QList<IWizardFactory*> IWizardFactory::allWizardFactories()
return s_allFactories;
}
QString IWizardFactory::runPath(const QString &defaultPath)
QString IWizardFactory::runPath(const QString &defaultPath) const
{
QString path = defaultPath;
if (path.isEmpty()) {
@@ -381,7 +381,7 @@ void IWizardFactory::clearWizardFactories()
s_areFactoriesLoaded = false;
}
QSet<Id> IWizardFactory::pluginFeatures() const
QSet<Id> IWizardFactory::pluginFeatures()
{
static QSet<Id> plugins;
if (plugins.isEmpty()) {
@@ -394,7 +394,7 @@ QSet<Id> IWizardFactory::pluginFeatures() const
return plugins;
}
QSet<Id> IWizardFactory::availableFeatures(Id platformId) const
QSet<Id> IWizardFactory::availableFeatures(Id platformId)
{
QSet<Id> availableFeatures;