feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use setAttribute(Qt::WA_DeleteOnClose) on context menus everywhere

Browse Source 
Helps thinking about menu and parent lifetime.

Change-Id: I120a16b4ebbd92187c5e8e78bd7da4ee9f2b115d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
hjk
2024-02-01 08:39:24 +01:00
parent a4fbc5f00d
commit 3f0649f07c
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/vcsbase/submiteditorwidget.cpp
View File

@@ -734,7 +734,8 @@ void SubmitEditorWidget::insertDescriptionEditContextMenuAction(int pos, QAction
void SubmitEditorWidget::editorCustomContextMenuRequested(const QPoint &pos)
{
QScopedPointer<QMenu> menu(d->description->createStandardContextMenu());
QMenu *menu = d->description->createStandardContextMenu();
menu->setAttribute(Qt::WA_DeleteOnClose);
// Extend
for (const SubmitEditorWidgetPrivate::AdditionalContextMenuAction &a :
std::as_const(d->descriptionEditContextMenuActions)) {