From 3f31dc6ceffca38232ec8e18431e7e05f60a0635 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Thu, 24 Jan 2019 15:59:31 +0100 Subject: [PATCH] ClangTools: Simplify/clarify labels in toolbar Change-Id: I64b8fdb4484bf920944d86ad01675dbda516d6c4 Reviewed-by: Leena Miettinen Reviewed-by: Ivan Donchevskii --- src/plugins/clangtools/clangtidyclazytool.cpp | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/plugins/clangtools/clangtidyclazytool.cpp b/src/plugins/clangtools/clangtidyclazytool.cpp index 3642452c601..1cf0c81fa4b 100644 --- a/src/plugins/clangtools/clangtidyclazytool.cpp +++ b/src/plugins/clangtools/clangtidyclazytool.cpp @@ -263,6 +263,7 @@ ClangTidyClazyTool::ClangTidyClazyTool() // Filter line edit m_filterLineEdit = new Utils::FancyLineEdit(); m_filterLineEdit->setFiltering(true); + m_filterLineEdit->setPlaceholderText(tr("Filter Issues")); m_filterLineEdit->setHistoryCompleter("CppTools.ClangTidyClazyIssueFilter", true); connect(m_filterLineEdit, &Utils::FancyLineEdit::filterChanged, [this](const QString &filter) { m_diagnosticFilterModel->setFilterRegExp( @@ -427,16 +428,17 @@ void ClangTidyClazyTool::handleStateUpdate() m_goNext->setEnabled(issuesVisible > 1); QString message; - if (m_running) - message = tr("Clang-Tidy and Clazy are running."); - else - message = tr("Clang-Tidy and Clazy finished."); - - message += QLatin1Char(' '); - if (issuesFound == 0) - message += tr("No issues found."); - else - message += tr("%n issues found.", nullptr, issuesFound); + if (m_running) { + if (issuesFound) + message = tr("Running - %n issues found", nullptr, issuesFound); + else + message = tr("Running - No issues found", nullptr, issuesFound); + } else { + if (issuesFound) + message = tr("Finished - %n issues found", nullptr, issuesFound); + else + message = tr("Finished - No issues found", nullptr, issuesFound); + } Debugger::showPermanentStatusMessage(message); }