feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

plugins: Remove foreach usage

Browse Source 
Change-Id: Idf60caed3b5f4ec4c6e990a9e3188487bcc824f8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Artem Sokolovskii
2022-12-20 10:58:39 +01:00
parent 2b97f69796
commit 3f340616d5
17 changed files with 56 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/shared/help/bookmarkmanager.cpp
View File

@@ -459,9 +459,10 @@ void BookmarkWidget::setup()
void BookmarkWidget::expandItems()
{
QStandardItemModel *model = bookmarkManager->treeBookmarkModel();
QList<QStandardItem*>list = model->findItems(QLatin1String("*"),
Qt::MatchWildcard | Qt::MatchRecursive, 0);
foreach (const QStandardItem* item, list) {
const QList<QStandardItem *> list = model->findItems(QLatin1String("*"),
Qt::MatchWildcard | Qt::MatchRecursive,
0);
for (const QStandardItem *item : list) {
const QModelIndex& index = model->indexFromItem(item);
treeView->setExpanded(filterBookmarkModel->mapFromSource(index),
item->data(Qt::UserRole + 11).toBool());
@@ -604,11 +605,12 @@ QStringList BookmarkManager::bookmarkFolders() const
{
QStringList folders(tr("Bookmarks"));
QList<QStandardItem*>list = treeModel->findItems(QLatin1String("*"),
Qt::MatchWildcard | Qt::MatchRecursive, 0);
const QList<QStandardItem *> list = treeModel->findItems(QLatin1String("*"),
Qt::MatchWildcard | Qt::MatchRecursive,
0);
QString data;
foreach (const QStandardItem *item, list) {
for (const QStandardItem *item : list) {
data = item->data(Qt::UserRole + 10).toString();
if (data == QLatin1String("Folder"))
folders << item->data(Qt::DisplayRole).toString();
@@ -649,8 +651,8 @@ void BookmarkManager::removeBookmarkItem(QTreeView *treeView,
}
if (data != QLatin1String("Folder")) {
QList<QStandardItem*>itemList = listModel->findItems(item->text());
foreach (const QStandardItem *i, itemList) {
const QList<QStandardItem *> itemList = listModel->findItems(item->text());
for (const QStandardItem *i : itemList) {
if (i->data(Qt::UserRole + 10) == data) {
listModel->removeRow(i->row());
break;
@@ -754,11 +756,12 @@ void BookmarkManager::setupBookmarkModels()
QString BookmarkManager::uniqueFolderName() const
{
QString folderName = tr("New Folder");
QList<QStandardItem*> list = treeModel->findItems(folderName,
Qt::MatchContains | Qt::MatchRecursive, 0);
const QList<QStandardItem *> list = treeModel->findItems(folderName,
Qt::MatchContains | Qt::MatchRecursive,
0);
if (!list.isEmpty()) {
QStringList names;
foreach (const QStandardItem *item, list)
for (const QStandardItem *item : list)
names << item->text();
QString folderNameBase = tr("New Folder") + QLatin1String(" %1");
@@ -779,8 +782,8 @@ void BookmarkManager::removeBookmarkFolderItems(QStandardItem *item)
removeBookmarkFolderItems(child);
QString data = child->data(Qt::UserRole + 10).toString();
QList<QStandardItem*>itemList = listModel->findItems(child->text());
foreach (const QStandardItem *i, itemList) {
const QList<QStandardItem*> itemList = listModel->findItems(child->text());
for (const QStandardItem *i : itemList) {
if (i->data(Qt::UserRole + 10) == data) {
listModel->removeRow(i->row());
break;