From 3f7fd1383e4d42accc29d497f4178a89a6d0f490 Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Fri, 15 Jan 2021 17:20:08 +0200 Subject: [PATCH] QmlDesigner: Fix crash when adding timeline and rootnode is not visual Fixes: QDS-3355 Change-Id: I2d3c13b29895cc723ac5dd43bafec38ba5a99305 Reviewed-by: Mahmoud Badri --- .../components/timelineeditor/timelinesettingsmodel.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/plugins/qmldesigner/components/timelineeditor/timelinesettingsmodel.cpp b/src/plugins/qmldesigner/components/timelineeditor/timelinesettingsmodel.cpp index 308a8d5052a..5b636592db3 100644 --- a/src/plugins/qmldesigner/components/timelineeditor/timelinesettingsmodel.cpp +++ b/src/plugins/qmldesigner/components/timelineeditor/timelinesettingsmodel.cpp @@ -173,9 +173,12 @@ void TimelineSettingsModel::resetModel() if (timelineView()->isAttached()) { addState(ModelNode()); - for (const QmlModelState &state : - QmlVisualNode(timelineView()->rootModelNode()).states().allStates()) - addState(state); + QmlVisualNode visNode(timelineView()->rootModelNode()); + if (visNode.isValid()) { + const auto allStates = visNode.states().allStates(); + for (const QmlModelState &state : allStates) + addState(state); + } } endResetModel();