From 3f86d555874ea642b944c7208f125b51ca7d34a0 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Tue, 13 Mar 2018 11:18:22 +0100
Subject: [PATCH] BareMetalRunConfigurationFactory: remove availableCreators
 reimp

The base version adds "(on $devicename)" which is even more information
than the generic "(on GDB server or hardware debugger)" here.

If the  bti.projectFilePath extra path bits are needed, the feature
could be made generally available in the base implementation.

Also fix a typo in the BareMetalCustomRunConfiguration title

Change-Id: I293e36c7edd2a9459e29a7025ca5bb19fb39b4b0
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
---
 .../baremetal/baremetalrunconfigurationfactory.cpp     | 10 +---------
 .../baremetal/baremetalrunconfigurationfactory.h       |  3 ---
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/src/plugins/baremetal/baremetalrunconfigurationfactory.cpp b/src/plugins/baremetal/baremetalrunconfigurationfactory.cpp
index 6de804890dc..2e88979ca9e 100644
--- a/src/plugins/baremetal/baremetalrunconfigurationfactory.cpp
+++ b/src/plugins/baremetal/baremetalrunconfigurationfactory.cpp
@@ -46,18 +46,10 @@ BareMetalRunConfigurationFactory::BareMetalRunConfigurationFactory()
     addSupportedTargetDeviceType(BareMetal::Constants::BareMetalOsType);
 }
 
-QList<RunConfigurationCreationInfo> BareMetalRunConfigurationFactory::availableCreators(Target *parent) const
-{
-    return Utils::transform(parent->applicationTargets().list, [this](const BuildTargetInfo &bti) {
-        return convert(tr("%1 (on GDB server or hardware debugger)").arg(QFileInfo(bti.targetName).fileName()),
-                       bti.projectFilePath.toString() + '/' + bti.targetName);
-    });
-}
-
 // BareMetalCustomRunConfigurationFactory
 
 BareMetalCustomRunConfigurationFactory::BareMetalCustomRunConfigurationFactory() :
-    FixedRunConfigurationFactory(BareMetalCustomRunConfiguration::tr("Custom Executable)"), true)
+    FixedRunConfigurationFactory(BareMetalCustomRunConfiguration::tr("Custom Executable"), true)
 {
     registerRunConfiguration<BareMetalCustomRunConfiguration>("BareMetal.CustomRunConfig");
     addSupportedTargetDeviceType(BareMetal::Constants::BareMetalOsType);
diff --git a/src/plugins/baremetal/baremetalrunconfigurationfactory.h b/src/plugins/baremetal/baremetalrunconfigurationfactory.h
index cb6fc097ff1..abdd4e438cb 100644
--- a/src/plugins/baremetal/baremetalrunconfigurationfactory.h
+++ b/src/plugins/baremetal/baremetalrunconfigurationfactory.h
@@ -36,9 +36,6 @@ class BareMetalRunConfigurationFactory : public ProjectExplorer::RunConfiguratio
 
 public:
     BareMetalRunConfigurationFactory();
-
-    QList<ProjectExplorer::RunConfigurationCreationInfo>
-    availableCreators(ProjectExplorer::Target *parent) const override;
 };
 
 class BareMetalCustomRunConfigurationFactory : public ProjectExplorer::FixedRunConfigurationFactory