From 40480c24fc287eadb794450d87dbc8ad5bf9a0d8 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@qt.io>
Date: Wed, 15 Jan 2025 13:25:40 +0100
Subject: [PATCH] Crashpad: Fix linking on Windows

Looks like symbols moved to client/common.lib (CrashReportDatabase,
CrashpadInfo, Settings) in newer versions of Crashpad.
Need to link against it to avoid missing symbols.

Change-Id: I18506105c098379ee9325138ca4a5197a622e2f7
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
---
 cmake/FindCrashpad.cmake | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/cmake/FindCrashpad.cmake b/cmake/FindCrashpad.cmake
index 181c4b0518d..ad28475a06a 100644
--- a/cmake/FindCrashpad.cmake
+++ b/cmake/FindCrashpad.cmake
@@ -69,10 +69,16 @@ if(Crashpad_FOUND)
     "${CRASHPAD_INCLUDE_DIR}/third_party/mini_chromium/mini_chromium"
     "${CRASHPAD_GEN_DIR}")
   if(WIN32)
+    set(COMMON_LIB "${CRASHPAD_LIB_DIR}/client/common.lib")
+    # might not exist in older versions
+    if (NOT EXISTS "${COMMON_LIB}")
+      set(COMMON_LIB "")
+    endif()
     target_link_libraries(Crashpad::Crashpad INTERFACE
       "${CRASHPAD_LIB_DIR}/third_party/mini_chromium/mini_chromium/base/base.lib"
       "${CRASHPAD_LIB_DIR}/util/util.lib"
       "${CRASHPAD_LIB_DIR}/client/client.lib"
+      "${COMMON_LIB}"
       advapi32)
     set_target_properties(Crashpad::Crashpad PROPERTIES
       IMPORTED_LOCATION "${CRASHPAD_LIB_DIR}/client/client.lib")