feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Theming: Do not set the global palette

Browse Source 
Setting the global palette is not a very good idea, because
it interferes with native styling.

On Windows 7 the dark theme was unuasable, because the text on
all natives controls was to bright.

All native controls and the global palette should be left alone.
Wherever we want styling/theming we have to use Manhatten style.

Change-Id: Ia1d0bfb190e4bde7be72f751afc0846570c1189d
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Thomas Hartmann
2014-10-16 10:30:38 +02:00
committed by hjk
parent fdc903b332
commit 4073016aba
2 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/coreplugin/coreplugin.cpp
View File

@@ -130,7 +130,6 @@ void CorePlugin::parseArguments(const QStringList &arguments)
Theme *theme = new Theme(qApp); Theme *theme = new Theme(qApp);
theme->readSettings(themeSettings); theme->readSettings(themeSettings);
setCreatorTheme(theme); setCreatorTheme(theme);
qApp->setPalette(creatorTheme()->palette(qApp->palette()));
// defer creation of these widgets until here, // defer creation of these widgets until here,
// because they need a valid theme set // because they need a valid theme set

1
src/plugins/coreplugin/themesettings.cpp
View File

@@ -435,7 +435,6 @@ void ThemeSettings::apply()
{ {
d->m_ui->editor->model()->toTheme(creatorTheme()); d->m_ui->editor->model()->toTheme(creatorTheme());
QPalette newPalette = creatorTheme()->palette(qApp->palette()); QPalette newPalette = creatorTheme()->palette(qApp->palette());
qApp->setPalette(newPalette);
foreach (QWidget *w, QApplication::topLevelWidgets()) foreach (QWidget *w, QApplication::topLevelWidgets())
w->update(); w->update();
} }