From 4097591301a12bfd226bbc6795b41ade128062f8 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 13 Apr 2011 15:10:46 +0200 Subject: [PATCH] Maemo: Use ABI for determining the gdb architecture string. Can't use MADDE, because it is outdated. Reviewed-by: Tobias Hunger Task-number: QTCREATORBUG-4299 --- .../qt-maemo/qt4maemotarget.cpp | 23 +++++++++---------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/plugins/qt4projectmanager/qt-maemo/qt4maemotarget.cpp b/src/plugins/qt4projectmanager/qt-maemo/qt4maemotarget.cpp index 1f7ad3ba76e..5f849ca0b7d 100644 --- a/src/plugins/qt4projectmanager/qt-maemo/qt4maemotarget.cpp +++ b/src/plugins/qt4projectmanager/qt-maemo/qt4maemotarget.cpp @@ -42,9 +42,11 @@ #include #include #include +#include #include #include #include +#include #include #include @@ -125,18 +127,15 @@ AbstractQt4MaemoTarget::~AbstractQt4MaemoTarget() AbstractQt4MaemoTarget::DebugArchitecture AbstractQt4MaemoTarget::debugArchitecture() const { - const QString arch - = MaemoGlobal::architecture(activeBuildConfiguration()->qtVersion()); - if (arch.startsWith(QLatin1String("arm"))) { - return DebugArchitecture(QLatin1String("arm"), - QLatin1String("arm-none-linux-gnueabi")); - } else if (arch.startsWith(QLatin1String("x86_64"))) { - return DebugArchitecture(QLatin1String("i386:x86-64"), - QLatin1String("x86_64-unknown-linux-gnu ")); - } else { - return DebugArchitecture(QLatin1String("x86"), - QLatin1String("i386-unknown-linux-gnu ")); - } + // TODO: This functionality should be inside the debugger. + const ProjectExplorer::Abi &abi + = activeBuildConfiguration()->toolChain()->targetAbi(); + DebugArchitecture arch(abi.toString()); + + // TODO: This might do the wrong thing for x64. + arch.gnuTarget = QLatin1String(abi.architecture() == ProjectExplorer::Abi::ArmArchitecture + ? "arm-none-linux-gnueabi": "i386-unknown-linux-gnu"); + return arch; } QList AbstractQt4MaemoTarget::possibleToolChains(ProjectExplorer::BuildConfiguration *bc) const