feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

fix access to uninitialized m_core member that should have not been

Browse Source 
there anymore
This commit is contained in:
hjk
2009-01-20 17:57:07 +01:00
parent 757ea7210c
commit 40a91b315b
2 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cppeditor/cppeditor.cpp
View File

@@ -334,10 +334,10 @@ void CPPEditor::jumpToMethod(int)
if (! symbol) if (! symbol)
return; return;
m_core->editorManager()->addCurrentPositionToNavigationHistory(true); Core::ICore::instance()->editorManager()->addCurrentPositionToNavigationHistory(true);
int line = symbol->line(); int line = symbol->line();
gotoLine(line); gotoLine(line);
m_core->editorManager()->addCurrentPositionToNavigationHistory(); Core::ICore::instance()->editorManager()->addCurrentPositionToNavigationHistory();
setFocus(); setFocus();
} }
@@ -655,7 +655,7 @@ void CPPEditor::contextMenuEvent(QContextMenuEvent *e)
menu->removeAction(lastAction); menu->removeAction(lastAction);
Core::ActionContainer *mcontext = Core::ActionContainer *mcontext =
m_core->actionManager()->actionContainer(CppEditor::Constants::M_CONTEXT); Core::ICore::instance()->actionManager()->actionContainer(CppEditor::Constants::M_CONTEXT);
QMenu *contextMenu = mcontext->menu(); QMenu *contextMenu = mcontext->menu();
foreach (QAction *action, contextMenu->actions()) foreach (QAction *action, contextMenu->actions())

9
src/plugins/cppeditor/cppeditor.h
View File

@@ -35,20 +35,14 @@
#define CPPEDITOR_H #define CPPEDITOR_H
#include "cppeditorenums.h" #include "cppeditorenums.h"
#include <cplusplus/CppDocument.h> #include <cplusplus/CppDocument.h>
#include <texteditor/basetexteditor.h> #include <texteditor/basetexteditor.h>
#include <QtCore/QObject>
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
class QAction;
class QComboBox; class QComboBox;
class QStringListModel;
QT_END_NAMESPACE QT_END_NAMESPACE
namespace Core {
class ICore;
}
namespace CPlusPlus { namespace CPlusPlus {
class OverviewModel; class OverviewModel;
class Symbol; class Symbol;
@@ -136,7 +130,6 @@ private:
bool openEditorAt(CPlusPlus::Symbol *symbol); bool openEditorAt(CPlusPlus::Symbol *symbol);
Core::ICore *m_core;
CppTools::CppModelManagerInterface *m_modelManager; CppTools::CppModelManagerInterface *m_modelManager;
QList<int> m_contexts; QList<int> m_contexts;