feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Move some translated strings from .h to .cpp

Browse Source 
Default values shouldn't have complex initializations anyway,
these end up in each instance on user side.

Change-Id: I81394c3df353b34b19454130f58bd646318feccd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
hjk
2023-02-08 12:28:16 +01:00
committed by Alessandro Portale
parent a6ccfb09e5
commit 40b295cbab
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libs/utils/aspects.cpp
View File

@@ -2010,14 +2010,14 @@ void DoubleAspect::setSingleStep(double step)
Its visual representation is a QComboBox with three items. Its visual representation is a QComboBox with three items.
*/ */
TriStateAspect::TriStateAspect(const QString onString, const QString &offString, TriStateAspect::TriStateAspect(const QString &onString, const QString &offString,
const QString &defaultString) const QString &defaultString)
{ {
setDisplayStyle(DisplayStyle::ComboBox); setDisplayStyle(DisplayStyle::ComboBox);
setDefaultValue(TriState::Default); setDefaultValue(TriState::Default);
addOption(onString); addOption(onString.isEmpty() ? Tr::tr("Enable") : onString);
addOption(offString); addOption(offString.isEmpty() ? Tr::tr("Disable") : offString);
addOption(defaultString); addOption(defaultString.isEmpty() ? Tr::tr("Leave at Default") : defaultString);
} }
TriState TriStateAspect::value() const TriState TriStateAspect::value() const

8
src/libs/utils/aspects.h
View File

@@ -499,11 +499,11 @@ private:
class QTCREATOR_UTILS_EXPORT TriStateAspect : public SelectionAspect class QTCREATOR_UTILS_EXPORT TriStateAspect : public SelectionAspect
{ {
Q_OBJECT Q_OBJECT
public: public:
TriStateAspect( TriStateAspect(const QString &onString = {},
const QString onString = QCoreApplication::tr("::Utils", "Enable"), const QString &offString = {},
const QString &offString = QCoreApplication::tr("::Utils", "Disable"), const QString &defaultString = {});
const QString &defaultString = QCoreApplication::tr("::Utils", "Leave at Default"));
TriState value() const; TriState value() const;
void setValue(TriState setting); void setValue(TriState setting);