feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Mark destructor of base class as virtual

Browse Source 
Change-Id: I8824299ac22ebf14cfbba088cbc555a1c7d53b5e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Tobias Hunger
2016-11-29 12:58:13 +01:00
parent f82edded08
commit 40ed154172
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/valgrind/callgrind/callgrindfunction.cpp
View File

@@ -45,12 +45,8 @@ namespace Callgrind {
Function::Private::Private(const ParseData *data) Function::Private::Private(const ParseData *data)
: m_data(data) : m_data(data)
, m_fileId(-1)
, m_objectId(-1)
, m_nameId(-1)
, m_selfCost(data->events().size(), 0) , m_selfCost(data->events().size(), 0)
, m_inclusiveCost(data->events().size(), 0) , m_inclusiveCost(data->events().size(), 0)
, m_called(0)
{ {
} }

10
src/plugins/valgrind/callgrind/callgrindfunction_p.h
View File

@@ -40,7 +40,7 @@ class Function::Private
{ {
public: public:
Private(const ParseData *data); Private(const ParseData *data);
~Private(); virtual ~Private();
static void accumulateCost(QVector<quint64> &base, const QVector<quint64> &add); static void accumulateCost(QVector<quint64> &base, const QVector<quint64> &add);
enum CallType { enum CallType {
@@ -51,9 +51,9 @@ public:
FunctionCall *accumulateCall(const FunctionCall *call, CallType type); FunctionCall *accumulateCall(const FunctionCall *call, CallType type);
const ParseData *m_data; const ParseData *m_data;
qint64 m_fileId; qint64 m_fileId = -1;
qint64 m_objectId; qint64 m_objectId = -1;
qint64 m_nameId; qint64 m_nameId = -1;
QVector<quint64> m_selfCost; QVector<quint64> m_selfCost;
QVector<quint64> m_inclusiveCost; QVector<quint64> m_inclusiveCost;
@@ -65,7 +65,7 @@ public:
// used in public api, hence const // used in public api, hence const
QVector<const FunctionCall *> m_outgoingCalls; QVector<const FunctionCall *> m_outgoingCalls;
QVector<const FunctionCall *> m_incomingCalls; QVector<const FunctionCall *> m_incomingCalls;
quint64 m_called; quint64 m_called = 0;
}; };
} // namespace Callgrind } // namespace Callgrind