feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Crashpad: Do not start if not enabled

Browse Source 
If the user doesn't have enabled crashreports, even local saving should
be disabled.

Change-Id: I809389eba7c1acf0d3a8429dfe3c648f3b56542e
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Eike Ziller
2024-10-10 17:46:11 +02:00
parent 20a21b3472
commit 413ccc3076
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/app/main.cpp
View File

@@ -410,8 +410,11 @@ QStringList lastSessionArgument()
} }
#ifdef ENABLE_CRASHPAD #ifdef ENABLE_CRASHPAD
bool startCrashpad(const AppInfo &appInfo, bool crashReportingEnabled) void startCrashpad(const AppInfo &appInfo, bool crashReportingEnabled)
{ {
if (!crashReportingEnabled)
return;
using namespace crashpad; using namespace crashpad;
// Cache directory that will store crashpad information and minidumps // Cache directory that will store crashpad information and minidumps
@@ -445,7 +448,7 @@ bool startCrashpad(const AppInfo &appInfo, bool crashReportingEnabled)
arguments.push_back("--no-rate-limit"); arguments.push_back("--no-rate-limit");
CrashpadClient *client = new CrashpadClient(); CrashpadClient *client = new CrashpadClient();
bool success = client->StartHandler( client->StartHandler(
handler, handler,
database, database,
database, database,
@@ -453,10 +456,7 @@ bool startCrashpad(const AppInfo &appInfo, bool crashReportingEnabled)
annotations, annotations,
arguments, arguments,
/* restartable */ true, /* restartable */ true,
/* asynchronous_start */ true /* asynchronous_start */ true);
);
return success;
} }
#endif #endif