From 4180e1b84f43cc39119e003457f76be518588107 Mon Sep 17 00:00:00 2001
From: Orgad Shaneh <orgad.shaneh@audiocodes.com>
Date: Sun, 3 Jul 2022 10:40:38 +0300
Subject: [PATCH] CodeAssist: Fix Coverity issues

* Initialize m_reason in IAssistProposal.
* Remove superfluous null validations.

Change-Id: Icb9b7a7a98db719540586142e30be75f37a4ab92
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
---
 src/plugins/texteditor/codeassist/codeassistant.cpp | 4 ++--
 src/plugins/texteditor/codeassist/iassistproposal.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/plugins/texteditor/codeassist/codeassistant.cpp b/src/plugins/texteditor/codeassist/codeassistant.cpp
index 50b5626ca76..22c937ac1c8 100644
--- a/src/plugins/texteditor/codeassist/codeassistant.cpp
+++ b/src/plugins/texteditor/codeassist/codeassistant.cpp
@@ -270,13 +270,13 @@ void CodeAssistantPrivate::requestProposal(AssistReason reason,
             if (processor != m_asyncProcessor)
                 return;
             invalidateCurrentRequestData();
-            if (processor && processor->needsRestart() && m_receivedContentWhileWaiting) {
+            if (processor->needsRestart() && m_receivedContentWhileWaiting) {
                 delete newProposal;
                 m_receivedContentWhileWaiting = false;
                 requestProposal(reason, m_assistKind, m_requestProvider);
             } else {
                 displayProposal(newProposal, reason);
-                if (processor && processor->running())
+                if (processor->running())
                     m_asyncProcessor = processor;
                 else
                     emit q->finished();
diff --git a/src/plugins/texteditor/codeassist/iassistproposal.h b/src/plugins/texteditor/codeassist/iassistproposal.h
index 1393cbab835..feb92caf9f2 100644
--- a/src/plugins/texteditor/codeassist/iassistproposal.h
+++ b/src/plugins/texteditor/codeassist/iassistproposal.h
@@ -65,7 +65,7 @@ protected:
     int m_basePosition;
     bool m_isFragile = false;
     bool m_supportsPrefix = true;
-    AssistReason m_reason;
+    AssistReason m_reason = IdleEditor;
 };
 
 } // TextEditor