feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: Avoid multiple lookups of help id for context help

Browse Source 
Context help would first query the database with potential IDs, and
afterwards the help plugin would look up the links for the resulting ID
again.
Pass the HelpItem (which potentially contains the cached links) directly
to context help.

Change-Id: I73bddcd3cd4eacaea412b98d53c5e5354a31f3d5
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2019-01-25 15:04:50 +01:00
parent c04c5c1575
commit 418dcfbcbb
17 changed files with 67 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/texteditor/texteditor.h
View File

@@ -33,6 +33,7 @@
#include <coreplugin/editormanager/editormanager.h>
#include <coreplugin/editormanager/ieditor.h>
#include <coreplugin/editormanager/ieditorfactory.h>
#include <coreplugin/helpitem.h>
#include <utils/link.h>
#include <utils/uncommentselection.h>
@@ -130,8 +131,8 @@ public:
bool restoreState(const QByteArray &state) override;
QWidget *toolBar() override;
void contextHelpId(const HelpIdCallback &callback) const override; // from IContext
void setContextHelpId(const QString &id) override;
void contextHelp(const HelpIdCallback &callback) const override; // from IContext
void setContextHelp(const Core::HelpItem &item) override;
int currentLine() const override;
int currentColumn() const override;
@@ -542,8 +543,8 @@ public:
QChar characterAt(int pos) const;
QString textAt(int from, int to) const;
void contextHelpId(const Core::IContext::HelpIdCallback &callback);
void setContextHelpId(const QString &id);
void contextHelpItem(const Core::IContext::HelpIdCallback &callback);
void setContextHelpItem(const Core::HelpItem &item);
static TextEditorWidget *currentTextEditorWidget();