From 4198cc14411b9e73fe6b7ed32c0d43343b66ce2d Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 24 Feb 2015 09:13:12 +0100 Subject: [PATCH] Debugger: Don't re-check pending LLDB breakpoints This partially reverts change 1d1695c2. This doesn't seem to be needed with recent versions of LLDB anymore and removes one source of "spurious" breakpoint-changed events. Change-Id: I8140944a46bbc83173c0088117a88110b0872e8a Reviewed-by: Christian Stenger --- share/qtcreator/debugger/lldbbridge.py | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/share/qtcreator/debugger/lldbbridge.py b/share/qtcreator/debugger/lldbbridge.py index a986707f0f9..76f7d3729fe 100644 --- a/share/qtcreator/debugger/lldbbridge.py +++ b/share/qtcreator/debugger/lldbbridge.py @@ -228,7 +228,6 @@ class Dumper(DumperBase): self.isShuttingDown_ = False self.isInterrupting_ = False self.dummyValue = None - self.breakpointsToCheck = set([]) self.qmlBreakpointResolvers = {} self.qmlTriggeredBreakpoint = None @@ -796,14 +795,6 @@ class Dumper(DumperBase): result += '],current-thread-id="%s"},' % self.currentThread().id self.report(result) - def reportChangedBreakpoints(self): - for i in xrange(0, self.target.GetNumBreakpoints()): - bp = self.target.GetBreakpointAtIndex(i) - if bp.GetID() in self.breakpointsToCheck: - if bp.GetNumLocations(): - self.breakpointsToCheck.remove(bp.GetID()) - self.report('breakpoint-changed={%s}' % self.describeBreakpoint(bp)) - def firstUsableFrame(self, thread): for i in xrange(10): frame = thread.GetFrameAtIndex(i) @@ -1325,7 +1316,6 @@ class Dumper(DumperBase): self.reportStackTop() self.reportThreads() self.reportLocation() - self.reportChangedBreakpoints() elif eventType == lldb.SBProcess.eBroadcastBitInterrupt: # 2 pass elif eventType == lldb.SBProcess.eBroadcastBitSTDOUT: @@ -1441,7 +1431,6 @@ class Dumper(DumperBase): bp.SetEnabled(int(args["enabled"])) if hasattr(bp, 'SetOneShot'): bp.SetOneShot(int(args["oneshot"])) - self.breakpointsToCheck.add(bp.GetID()) self.report('breakpoint-added={%s,modelid="%s"}' % (self.describeBreakpoint(bp), modelId)) def changeBreakpoint(self, args):