feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

MSVC: Improve error handling

Browse Source 
By not silently failing when the vcvars.bat file is not found. Instead attempt
to run it and report the error message when it fails.

Change-Id: Ib97dbe17f8fb5529e549ef6c5d132a8571c10c33
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tobias Hunger
2017-01-11 11:25:51 +01:00
committed by Tim Jenssen
parent c318f7b2a0
commit 41c1abab7e
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/msvctoolchain.cpp
View File

@@ -382,9 +382,6 @@ static QString winExpandDelayedEnvReferences(QString in, const Utils::Environmen
Utils::Environment MsvcToolChain::readEnvironmentSetting(const Utils::Environment& env) const
{
Utils::Environment result;
if (!QFileInfo::exists(m_vcvarsBat))
return env;
QMap<QString, QString> envPairs;
if (!generateEnvironmentSettings(env, m_vcvarsBat, m_varsBatArg, envPairs))
return env;

5
src/plugins/projectexplorer/wincetoolchain.cpp
View File

@@ -113,11 +113,6 @@ static QString winExpandDelayedEnvReferences(QString in, const Utils::Environmen
Utils::Environment WinCEToolChain::readEnvironmentSetting(const Utils::Environment &env) const
{
Utils::Environment result;
if (!QFileInfo::exists(m_vcvarsBat))
return env;
// Get the env pairs
QMap<QString, QString> envPairs;
if (!generateEnvironmentSettings(env, m_vcvarsBat, QString(), envPairs))