From 421a1cf93c1ec5e6fae088a3bfc6547cb8481738 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Mon, 12 Sep 2011 10:21:53 +0200 Subject: [PATCH] QmlDesigner.contextMenu: crash fix Task-number: QTCREATORBUG-6071 Change-Id: Iae2cc199cd8ec3809bc635084b8a8fa79bb36b08 Reviewed-on: http://codereview.qt-project.org/4643 Reviewed-by: Qt Sanity Bot Reviewed-by: Eike Ziller --- .../qmldesigner/designercore/model/modelnodecontextmenu.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmldesigner/designercore/model/modelnodecontextmenu.cpp b/src/plugins/qmldesigner/designercore/model/modelnodecontextmenu.cpp index 0333b5e4fcd..3ae4815cc2d 100644 --- a/src/plugins/qmldesigner/designercore/model/modelnodecontextmenu.cpp +++ b/src/plugins/qmldesigner/designercore/model/modelnodecontextmenu.cpp @@ -71,7 +71,7 @@ static inline bool checkIfNodeIsAView(const ModelNode &node) static inline bool isItem(const ModelNode &node) { - return node.metaInfo().isValid() && node.metaInfo().isSubclassOf("QtQuick.Item", -1, -1); + return node.isValid() && node.metaInfo().isValid() && node.metaInfo().isSubclassOf("QtQuick.Item", -1, -1); } static inline QList siblingsForNode(const QmlItemNode &itemNode) @@ -251,7 +251,7 @@ void ModelNodeContextMenu::execute(const QPoint &pos, bool selectionMenuBool) editMenu->addAction(action); action = createModelNodeAction(tr("Visibility"), editMenu, QList() << currentSingleNode, ModelNodeAction::ModelNodeVisibility, singleSelected); editMenu->addAction(action); - if (!isItem(currentSingleNode)) + if (singleSelected && !isItem(currentSingleNode)) action->setDisabled(true); } else {