Vcs: Register settings aspects more directly

Change-Id: I8049f71456b8e8573a2dcfce68a14fb12545865b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/vcsbase/vcsbaseclientsettings.cpp

@@ -6,15 +6,7 @@
 #include "vcsbasetr.h"
 
 #include <utils/algorithm.h>
-#include <utils/environment.h>
-#include <utils/fileutils.h>
 #include <utils/hostosinfo.h>
-#include <utils/qtcassert.h>
-#include <utils/qtcsettings.h>
-#include <utils/stringutils.h>
-
-#include <QSettings>
-#include <QVariant>
 
 using namespace Utils;
 
@@ -22,27 +14,19 @@ namespace VcsBase {
 
 VcsBaseSettings::VcsBaseSettings()
 {
-    setAutoApply(false);
-
-    registerAspect(&binaryPath);
     binaryPath.setSettingsKey("BinaryPath");
 
-    registerAspect(&userName);
     userName.setSettingsKey("Username");
 
-    registerAspect(&userEmail);
     userEmail.setSettingsKey("UserEmail");
 
-    registerAspect(&logCount);
     logCount.setSettingsKey("LogCount");
     logCount.setRange(0, 1000 * 1000);
     logCount.setDefaultValue(100);
     logCount.setLabelText(Tr::tr("Log count:"));
 
-    registerAspect(&path);
     path.setSettingsKey("Path");
 
-    registerAspect(&timeout);
     timeout.setSettingsKey("Timeout");
     timeout.setRange(0, 3600 * 24 * 365);
     timeout.setDefaultValue(30);