feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SquishTests: Don't filter out code model issues when we need them

Browse Source 
Amends c46dff0199

Change-Id: I5f2613edf15f86161a576ab21f16f079bd12a59f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Robert Löhning
2023-04-04 00:26:21 +02:00
parent 66f939c758
commit 42c653b53c
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/system/shared/build_utils.py
View File

@@ -23,14 +23,17 @@ def toggleIssuesFilter(filterName, checked):
test.log("Exception while toggling filter '%s'" % filterName, test.log("Exception while toggling filter '%s'" % filterName,
"%s(%s)" % (str(t), str(v))) "%s(%s)" % (str(t), str(v)))
def getBuildIssues():
def getBuildIssues(ignoreCodeModel=True):
ensureChecked(":Qt Creator_Issues_Core::Internal::OutputPaneToggleButton") ensureChecked(":Qt Creator_Issues_Core::Internal::OutputPaneToggleButton")
model = waitForObject(":Qt Creator.Issues_QListView").model() model = waitForObject(":Qt Creator.Issues_QListView").model()
# filter out possible code model issues present inside the Issues pane if ignoreCodeModel:
toggleIssuesFilter("Clang Code Model", False) # filter out possible code model issues present inside the Issues pane
toggleIssuesFilter("Clang Code Model", False)
result = dumpBuildIssues(model) result = dumpBuildIssues(model)
# reset the filter if ignoreCodeModel:
toggleIssuesFilter("Clang Code Model", True) # reset the filter
toggleIssuesFilter("Clang Code Model", True)
return result return result
# this method checks the last build (if there's one) and logs the number of errors, warnings and # this method checks the last build (if there's one) and logs the number of errors, warnings and

2
tests/system/suite_editors/tst_memberoperator/test.py
View File

@@ -25,7 +25,7 @@ def __noBuildIssues__():
def __syntaxErrorDetected__(): def __syntaxErrorDetected__():
buildIssues = getBuildIssues() buildIssues = getBuildIssues(False)
for issue in buildIssues: for issue in buildIssues:
if issue[3] in ["Expected ';' after expression (fix available)", if issue[3] in ["Expected ';' after expression (fix available)",
"Expected ';' at end of declaration (fix available)", "Expected ';' at end of declaration (fix available)",