Move the constants where they belong.

src/plugins/help/helpconstants.h

@@ -33,10 +33,17 @@
 #include <QtCore/QtGlobal>
 
 namespace Help {
-namespace Constants {
+    namespace Constants {
+
+const int          P_MODE_HELP    = 70;
+const char * const ID_MODE_HELP   = "Help";
 const char * const HELP_CATEGORY = "H.Help";
 const char * const HELP_TR_CATEGORY = QT_TRANSLATE_NOOP("Help", "Help");
-}
+
-}
+const char * const C_MODE_HELP    = "Help Mode";
+const char * const C_HELP_SIDEBAR = "Help Sidebar";
+
+    }   // Constants
+}   // Help
 
 #endif // HELPCONSTANTS_H

src/plugins/help/helpmode.cpp

@@ -28,7 +28,7 @@
 **************************************************************************/
 
 #include "helpmode.h"
-#include "helpplugin.h"
+#include "helpconstants.h"
 
 #include <coreplugin/findplaceholder.h>
 

src/plugins/help/helpplugin.cpp

@@ -34,6 +34,7 @@
 #include "docsettingspage.h"
 #include "filtersettingspage.h"
 #include "generalsettingspage.h"
+#include "helpconstants.h"
 #include "helpfindsupport.h"
 #include "helpindexfilter.h"
 #include "helpmanager.h"

src/plugins/help/helpplugin.h

@@ -60,13 +60,6 @@ class SideBarItem;
 namespace Help {
 class HelpManager;
 
-namespace Constants {
-const char * const C_MODE_HELP    = "Help Mode";
-const char * const C_HELP_SIDEBAR = "Help Sidebar";
-const int          P_MODE_HELP    = 70;
-const char * const ID_MODE_HELP   = "Help";
-}   // Constants
-
 namespace Internal {
 class CentralWidget;
 class DocSettingsPage;