feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Fix reset for write and execute in the sqlite statement

Browse Source 
We were not reset a statement if we got an exception. There are now test
for it.

Change-Id: Ife7b4437fece9369767605ba7387bd0564c1bb8d
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Marco Bubke
2018-04-04 10:41:11 +02:00
parent 9d7225d283
commit 42ecd2ed3d
6 changed files with 52 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/libs/sqlite/sqlitebasestatement.cpp
View File

@@ -54,8 +54,7 @@ BaseStatement::BaseStatement(Utils::SmallStringView sqlStatement, Database &data
void BaseStatement::deleteCompiledStatement(sqlite3_stmt *compiledStatement)
{
if (compiledStatement)
sqlite3_finalize(compiledStatement);
sqlite3_finalize(compiledStatement);
}
class UnlockNotification
@@ -145,12 +144,6 @@ void BaseStatement::step() const
next();
}
void BaseStatement::execute() const
{
next();
reset();
}
int BaseStatement::columnCount() const
{
return m_columnCount;