feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: clang-tidy fix for 'perf*-unnecessary-copy-initialization'

Browse Source 
Change-Id: I9c407f7254328e7278096239f6f3946c34e873d5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Cristian Adam
2023-10-20 14:46:33 +02:00
parent 60de12efd2
commit 43121fa574
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cmakeprojectmanager/cmakeconfigitem.cpp
View File

@@ -372,9 +372,9 @@ CMakeConfig CMakeConfig::fromFile(const Utils::FilePath &cacheFile, QString *err
continue; continue;
QTC_ASSERT(pieces.size() == 3, continue); QTC_ASSERT(pieces.size() == 3, continue);
const QByteArray key = pieces.at(0); const QByteArray &key = pieces.at(0);
const QByteArray type = pieces.at(1); const QByteArray &type = pieces.at(1);
const QByteArray value = pieces.at(2); const QByteArray &value = pieces.at(2);
if (key.endsWith("-ADVANCED") && value == "1") { if (key.endsWith("-ADVANCED") && value == "1") {
advancedSet.insert(key.left(key.size() - 9 /* "-ADVANCED" */)); advancedSet.insert(key.left(key.size() - 9 /* "-ADVANCED" */));

2
src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp
View File

@@ -1085,7 +1085,7 @@ void CMakeProjectImporter::persistTemporaryCMake(Kit *k, const QVariantList &vl)
if (vl.isEmpty()) if (vl.isEmpty())
return; // No temporary CMake return; // No temporary CMake
QTC_ASSERT(vl.count() == 1, return); QTC_ASSERT(vl.count() == 1, return);
const QVariant data = vl.at(0); const QVariant &data = vl.at(0);
CMakeTool *tmpCmake = CMakeToolManager::findById(Id::fromSetting(data)); CMakeTool *tmpCmake = CMakeToolManager::findById(Id::fromSetting(data));
CMakeTool *actualCmake = CMakeKitAspect::cmakeTool(k); CMakeTool *actualCmake = CMakeKitAspect::cmakeTool(k);

2
src/plugins/cmakeprojectmanager/cmaketool.cpp
View File

@@ -490,7 +490,7 @@ void CMakeTool::parseFunctionDetailsOutput(const QString &output)
const QStringList lines = output.split('\n'); const QStringList lines = output.split('\n');
for (int i = 0; i < lines.count(); ++i) { for (int i = 0; i < lines.count(); ++i) {
const QString line = lines.at(i); const QString &line = lines.at(i);
if (line == "::") { if (line == "::") {
expectDefinition = true; expectDefinition = true;