feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Don't access QmlProfilerTool from QmlProfilerTextMark

Browse Source 
Only QmlProfilerViewManager is needed, so use that, as a step to
reduce the interface of the QmlProfilerTool singleton.

Change-Id: I19e55e3b22b3c64ff98b8ea29cbc5164a60ee15d
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
hjk
2017-08-15 18:44:18 +02:00
parent 7458880298
commit 4342eeab33
4 changed files with 22 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/qmlprofiler/qmlprofilertextmark.h
View File

@@ -25,16 +25,18 @@
#pragma once
#include "qmleventlocation.h"
#include "qmlprofilertool.h"
#include <texteditor/textmark.h>
namespace QmlProfiler {
namespace Internal {
class QmlProfilerViewManager;
class QmlProfilerTextMark : public TextEditor::TextMark
{
public:
QmlProfilerTextMark(QmlProfilerTool *tool, int typeId, const QString &fileName, int lineNumber);
QmlProfilerTextMark(QmlProfilerViewManager *viewManager, int typeId,
const QString &fileName, int lineNumber);
void addTypeId(int typeId);
void paintIcon(QPainter *painter, const QRect &rect) const override;
@@ -43,7 +45,7 @@ public:
bool addToolTipContent(QLayout *target) const override;
private:
QmlProfilerTool *m_tool;
QmlProfilerViewManager *m_viewManager;
QVector<int> m_typeIds;
};
@@ -55,7 +57,7 @@ public:
void clear();
void addTextMarkId(int typeId, const QmlEventLocation &location);
void createMarks(QmlProfilerTool *tool, const QString &fileName);
void createMarks(QmlProfilerViewManager *viewManager, const QString &fileName);
private:
struct TextMarkId {