feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Remove unused arguments

Browse Source 
Change-Id: I72e6df2e0e5b94addbca79bbca6bf2aa7cff2042
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Nikolai Kosjar
2016-08-19 14:45:06 +02:00
parent 8b21f687c0
commit 4372514e6b
4 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/tools/clangbackend/ipcsource/clangjobqueue.cpp
View File

@@ -34,14 +34,9 @@
namespace ClangBackEnd {
JobQueue::JobQueue(TranslationUnits &translationUnits,
UnsavedFiles &unsavedFiles,
ProjectParts &projectParts,
ClangCodeModelClientInterface &client)
JobQueue::JobQueue(TranslationUnits &translationUnits, ProjectParts &projectParts)
: m_translationUnits(translationUnits)
, m_unsavedFiles(unsavedFiles)
, m_projectParts(projectParts)
, m_client(client)
{
}

9
src/tools/clangbackend/ipcsource/clangjobqueue.h
View File

@@ -31,18 +31,13 @@
namespace ClangBackEnd {
class ClangCodeModelClientInterface;
class ProjectParts;
class TranslationUnits;
class UnsavedFiles;
class JobQueue
{
public:
JobQueue(TranslationUnits &translationUnits,
UnsavedFiles &unsavedFiles,
ProjectParts &projects,
ClangCodeModelClientInterface &client);
JobQueue(TranslationUnits &translationUnits, ProjectParts &projects);
void add(const JobRequest &job);
@@ -65,9 +60,7 @@ private:
private:
TranslationUnits &m_translationUnits;
UnsavedFiles &m_unsavedFiles;
ProjectParts &m_projectParts;
ClangCodeModelClientInterface &m_client;
IsJobRunningHandler m_isJobRunningHandler;

2
src/tools/clangbackend/ipcsource/clangjobs.cpp
View File

@@ -44,7 +44,7 @@ Jobs::Jobs(TranslationUnits &translationUnits,
, m_unsavedFiles(unsavedFiles)
, m_projectParts(projectParts)
, m_client(client)
, m_queue(translationUnits, unsavedFiles, projectParts, client)
, m_queue(translationUnits, projectParts)
{
m_queue.setIsJobRunningHandler([this](const Utf8String &filePath,
const Utf8String &projectPartId) {

4
tests/unit/unittest/clangjobqueuetest.cpp
View File

@@ -24,7 +24,6 @@
****************************************************************************/
#include "testutils.h"
#include "dummyclangipcclient.h"
#include <clangjobs.h>
#include <clangtranslationunit.h>
@@ -78,13 +77,12 @@ protected:
ClangBackEnd::UnsavedFiles unsavedFiles;
ClangBackEnd::TranslationUnits translationUnits{projects, unsavedFiles};
ClangBackEnd::TranslationUnit translationUnit;
DummyIpcClient dummyClientInterface;
Utf8String filePath1 = Utf8StringLiteral(TESTDATA_DIR"/translationunits.cpp");
Utf8String filePath2 = Utf8StringLiteral(TESTDATA_DIR"/skippedsourceranges.cpp");
Utf8String projectPartId{Utf8StringLiteral("/path/to/projectfile")};
ClangBackEnd::JobQueue jobQueue{translationUnits, unsavedFiles, projects, dummyClientInterface};
ClangBackEnd::JobQueue jobQueue{translationUnits, projects};
};
TEST_F(JobQueue, AddJob)