feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Snippets: Code cosmetics

Browse Source 
Change-Id: I1586c8167b8c9797d2594255e4ba14329accec44
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Tobias Hunger
2016-08-18 12:00:57 +02:00
parent 79d889ca47
commit 437cb039e1
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/texteditor/snippets/snippet.cpp
View File

@@ -43,25 +43,27 @@ const char TCMANGLER_ID[] = "TextEditor::TitlecaseMangler";
// Manglers: // Manglers:
// -------------------------------------------------------------------- // --------------------------------------------------------------------
NameMangler::~NameMangler() = default;
class UppercaseMangler : public NameMangler class UppercaseMangler : public NameMangler
{ {
public: public:
Core::Id id() const { return UCMANGLER_ID; } Core::Id id() const final { return UCMANGLER_ID; }
QString mangle(const QString &unmangled) const { return unmangled.toUpper(); } QString mangle(const QString &unmangled) const final { return unmangled.toUpper(); }
}; };
class LowercaseMangler : public NameMangler class LowercaseMangler : public NameMangler
{ {
public: public:
Core::Id id() const { return LCMANGLER_ID; } Core::Id id() const final { return LCMANGLER_ID; }
QString mangle(const QString &unmangled) const { return unmangled.toLower(); } QString mangle(const QString &unmangled) const final { return unmangled.toLower(); }
}; };
class TitlecaseMangler : public NameMangler class TitlecaseMangler : public NameMangler
{ {
public: public:
Core::Id id() const { return TCMANGLER_ID; } Core::Id id() const final { return TCMANGLER_ID; }
QString mangle(const QString &unmangled) const QString mangle(const QString &unmangled) const final
{ {
QString result = unmangled; QString result = unmangled;
if (!result.isEmpty()) if (!result.isEmpty())
@@ -77,8 +79,7 @@ public:
const QChar Snippet::kVariableDelimiter(QLatin1Char('$')); const QChar Snippet::kVariableDelimiter(QLatin1Char('$'));
const QChar Snippet::kEscapeChar(QLatin1Char('\\')); const QChar Snippet::kEscapeChar(QLatin1Char('\\'));
Snippet::Snippet(const QString &groupId, const QString &id) : Snippet::Snippet(const QString &groupId, const QString &id) : m_groupId(groupId), m_id(id)
m_isRemoved(false), m_isModified(false), m_groupId(groupId), m_id(id)
{} {}
Snippet::~Snippet() Snippet::~Snippet()

6
src/plugins/texteditor/snippets/snippet.h
View File

@@ -38,7 +38,7 @@ namespace TextEditor {
class TEXTEDITOR_EXPORT NameMangler class TEXTEDITOR_EXPORT NameMangler
{ {
public: public:
virtual ~NameMangler() { } virtual ~NameMangler();
virtual Core::Id id() const = 0; virtual Core::Id id() const = 0;
virtual QString mangle(const QString &unmangled) const = 0; virtual QString mangle(const QString &unmangled) const = 0;
@@ -92,8 +92,8 @@ public:
static ParsedSnippet parse(const QString &snippet); static ParsedSnippet parse(const QString &snippet);
private: private:
bool m_isRemoved; bool m_isRemoved = false;
bool m_isModified; bool m_isModified = false;
QString m_groupId; QString m_groupId;
QString m_id; // Only built-in snippets have an id. QString m_id; // Only built-in snippets have an id.
QString m_trigger; QString m_trigger;