feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Rename CMakeConfigurationKitAspect{Widget->Impl}

Browse Source 
It's not a widget.

Change-Id: I617dd189cbdc815bf9055ab4908dc7239b784e64
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
hjk
2024-07-02 16:09:39 +02:00
parent 02e3de5bd9
commit 43977018b6
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/cmakeprojectmanager/cmakekitaspect.cpp
View File

@@ -872,10 +872,10 @@ const char CMAKE_QMAKE_KEY[] = "QT_QMAKE_EXECUTABLE";
const char CMAKE_PREFIX_PATH_KEY[] = "CMAKE_PREFIX_PATH"; const char CMAKE_PREFIX_PATH_KEY[] = "CMAKE_PREFIX_PATH";
const char QTC_CMAKE_PRESET_KEY[] = "QTC_CMAKE_PRESET"; const char QTC_CMAKE_PRESET_KEY[] = "QTC_CMAKE_PRESET";
class CMakeConfigurationKitAspectWidget final : public KitAspect class CMakeConfigurationKitAspectImpl final : public KitAspect
{ {
public: public:
CMakeConfigurationKitAspectWidget(Kit *kit, const KitAspectFactory *factory) CMakeConfigurationKitAspectImpl(Kit *kit, const KitAspectFactory *factory)
: KitAspect(kit, factory), : KitAspect(kit, factory),
m_summaryLabel(createSubWidget<ElidingLabel>()), m_summaryLabel(createSubWidget<ElidingLabel>()),
m_manageButton(createSubWidget<QPushButton>()) m_manageButton(createSubWidget<QPushButton>())
@@ -883,7 +883,7 @@ public:
refresh(); refresh();
m_manageButton->setText(Tr::tr("Change...")); m_manageButton->setText(Tr::tr("Change..."));
connect(m_manageButton, &QAbstractButton::clicked, connect(m_manageButton, &QAbstractButton::clicked,
this, &CMakeConfigurationKitAspectWidget::editConfigurationChanges); this, &CMakeConfigurationKitAspectImpl::editConfigurationChanges);
} }
private: private:
@@ -982,10 +982,10 @@ private:
CMakeConfigurationKitAspect::defaultConfiguration(kit())); CMakeConfigurationKitAspect::defaultConfiguration(kit()));
CMakeConfigurationKitAspect::setAdditionalConfiguration(kit(), QString()); CMakeConfigurationKitAspect::setAdditionalConfiguration(kit(), QString());
}); });
connect(m_dialog, &QDialog::accepted, this, &CMakeConfigurationKitAspectWidget::acceptChangesDialog); connect(m_dialog, &QDialog::accepted, this, &CMakeConfigurationKitAspectImpl::acceptChangesDialog);
connect(m_dialog, &QDialog::rejected, this, &CMakeConfigurationKitAspectWidget::closeChangesDialog); connect(m_dialog, &QDialog::rejected, this, &CMakeConfigurationKitAspectImpl::closeChangesDialog);
connect(buttons->button(QDialogButtonBox::Apply), &QAbstractButton::clicked, connect(buttons->button(QDialogButtonBox::Apply), &QAbstractButton::clicked,
this, &CMakeConfigurationKitAspectWidget::applyChanges); this, &CMakeConfigurationKitAspectImpl::applyChanges);
refresh(); refresh();
m_dialog->show(); m_dialog->show();
@@ -1254,7 +1254,7 @@ KitAspect *CMakeConfigurationKitAspectFactory::createKitAspect(Kit *k) const
{ {
if (!k) if (!k)
return nullptr; return nullptr;
return new CMakeConfigurationKitAspectWidget(k, this); return new CMakeConfigurationKitAspectImpl(k, this);
} }
// Factory instances; // Factory instances;