feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: Move resolution of help from multiple candidate IDs to HelpItem

Browse Source 
No need for code duplication.

Change-Id: I3d2c795d072b8de5818e1844b8126e526339c0da
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2019-01-28 13:00:03 +01:00
parent 1f4b733cc1
commit 443931c1da
12 changed files with 81 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/cmakeprojectmanager/cmakeeditor.cpp
View File

@@ -71,7 +71,7 @@ void CMakeEditor::contextHelp(const HelpCallback &callback) const
break;
chr = characterAt(pos);
if (chr == QLatin1Char('(')) {
callback(QString());
callback({});
return;
}
} while (chr.unicode() != QChar::ParagraphSeparator);
@@ -97,12 +97,12 @@ void CMakeEditor::contextHelp(const HelpCallback &callback) const
// Not a command
if (chr != QLatin1Char('(')) {
callback(QString());
callback({});
return;
}
QString command = textAt(begin, end - begin).toLower();
callback(QString("command/" + command));
const QString id = "command/" + textAt(begin, end - begin).toLower();
callback(id);
}
//