feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Process: Get rid of ProcessInterpreter

Browse Source 
Move it locally to the only one user: VcsCommand.

For the future similar usages: use ProcessTask
and tweak the DoneResult inside TaskDoneHandler.

Change-Id: Icdffee7f1963f3ff377bfa6309e14bd1862a2c1f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2024-01-17 00:21:44 +01:00
parent 6042f6fde4
commit 443ce8e164
7 changed files with 10 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/vcsbase/vcsbaseclient.h
View File

@@ -4,9 +4,9 @@
#pragma once
#include "vcsbase_global.h"
#include "vcsenums.h"
#include "vcsbaseclientsettings.h"
#include "vcscommand.h"
#include "vcsenums.h"
#include <utils/fileutils.h>
#include <utils/id.h>
@@ -32,7 +32,6 @@ namespace VcsBase {
class CommandResult;
class VcsBaseEditorConfig;
class VcsBaseEditorWidget;
class VcsCommand;
using CommandHandler = std::function<void(const CommandResult &)>;
@@ -61,7 +60,7 @@ public:
const QStringList &args) const;
void enqueueJob(VcsCommand *cmd, const QStringList &args,
const Utils::ExitCodeInterpreter &interpreter = {}) const;
const ExitCodeInterpreter &interpreter = {}) const;
virtual Utils::Environment processEnvironment() const;
@@ -207,7 +206,7 @@ public:
protected:
virtual QString vcsCommandString(VcsCommandTag cmd) const;
virtual Utils::Id vcsEditorKind(VcsCommandTag cmd) const = 0;
virtual Utils::ExitCodeInterpreter exitCodeInterpreter(VcsCommandTag cmd) const;
virtual ExitCodeInterpreter exitCodeInterpreter(VcsCommandTag) const { return {}; }
virtual QStringList revisionSpec(const QString &/*revision*/) const { return {}; }