feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtVersionNumber: Fix crash

Browse Source 
Checking the string for validity is not enough, actually bailing out if
it is invalid is better...
This commit is contained in:
dt
2011-02-22 17:35:34 +01:00
parent 7effd0e23e
commit 4440a3b726
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qt4projectmanager/qtversionmanager.cpp
View File

@@ -1938,8 +1938,10 @@ QtVersionNumber::QtVersionNumber(int ma, int mi, int p)
QtVersionNumber::QtVersionNumber(const QString &versionString) QtVersionNumber::QtVersionNumber(const QString &versionString)
{ {
if (!checkVersionString(versionString)) if (!checkVersionString(versionString)) {
majorVersion = minorVersion = patchVersion = -1; majorVersion = minorVersion = patchVersion = -1;
return;
}
QStringList parts = versionString.split(QLatin1Char('.')); QStringList parts = versionString.split(QLatin1Char('.'));
majorVersion = parts.at(0).toInt(); majorVersion = parts.at(0).toInt();