From 44836247ca6230b55f560eada727667f4cb52ce7 Mon Sep 17 00:00:00 2001
From: Artem Sokolovskii <artem.sokolovskii@qt.io>
Date: Mon, 2 Oct 2023 10:01:28 +0200
Subject: [PATCH] DAP: Fix coverity warning

Change-Id: Ieb8cc7133b9b2dea4a4d97ec109f82dac28f7950
Coverity-Id: 1568465
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
---
 src/plugins/debugger/dap/dapengine.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/plugins/debugger/dap/dapengine.cpp b/src/plugins/debugger/dap/dapengine.cpp
index d722c14019c..686df98c472 100644
--- a/src/plugins/debugger/dap/dapengine.cpp
+++ b/src/plugins/debugger/dap/dapengine.cpp
@@ -476,13 +476,14 @@ void DapEngine::updateItem(const QString &iname)
 void DapEngine::reexpandItems(const QSet<QString> &inames)
 {
     QSet<QString> expandedInames = inames;
-    for (auto inames : watchHandler()->watcherNames().keys())
+    const QList<QString> &watcherNames = watchHandler()->watcherNames().keys();
+    for (const QString &inames : watcherNames)
         expandedInames.insert(watchHandler()->watcherName(inames));
 
-    QList<QString> inamesVector = expandedInames.values().toVector();
+    QList<QString> inamesVector = expandedInames.values();
     inamesVector.sort();
 
-    for (const QString &iname : inamesVector) {
+    for (const QString &iname : std::as_const(inamesVector)) {
         if (iname.startsWith("local.") || iname.startsWith("watch."))
             m_variablesHandler->addVariable(iname, -1);
     }