diff --git a/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.cpp b/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.cpp index a0a41df6540..ff0974b1fd7 100644 --- a/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.cpp +++ b/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.cpp @@ -29,35 +29,9 @@ namespace QmlDesigner { -ChangeIdsCommand::ChangeIdsCommand() = default; - -ChangeIdsCommand::ChangeIdsCommand(const QVector &idVector) - : m_idVector(idVector) -{ -} - -QVector ChangeIdsCommand::ids() const -{ - return m_idVector; -} - -QDataStream &operator<<(QDataStream &out, const ChangeIdsCommand &command) -{ - out << command.ids(); - - return out; -} - -QDataStream &operator>>(QDataStream &in, ChangeIdsCommand &command) -{ - in >> command.m_idVector; - - return in; -} - QDebug operator <<(QDebug debug, const ChangeIdsCommand &command) { - return debug.nospace() << "ChangeIdsCommand(ids: " << command.m_idVector << ")"; + return debug.nospace() << "ChangeIdsCommand(ids: " << command.ids << ")"; } } // namespace QmlDesigner diff --git a/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.h b/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.h index b92fb3b558c..cb6ec1a617f 100644 --- a/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.h +++ b/share/qtcreator/qml/qmlpuppet/commands/changeidscommand.h @@ -27,7 +27,7 @@ #include #include - +#include #include "idcontainer.h" @@ -35,24 +35,23 @@ namespace QmlDesigner { class ChangeIdsCommand { - friend QDataStream &operator>>(QDataStream &in, ChangeIdsCommand &command); +public: + friend QDataStream &operator>>(QDataStream &in, ChangeIdsCommand &command) + { + in >> command.ids; + return in; + } + + friend QDataStream &operator<<(QDataStream &out, const ChangeIdsCommand &command) + { + out << command.ids; + return out; + } friend QDebug operator <<(QDebug debug, const ChangeIdsCommand &command); -public: - ChangeIdsCommand(); - explicit ChangeIdsCommand(const QVector &idVector); - - QVector ids() const; - -private: - QVector m_idVector; + QVector ids; }; -QDataStream &operator<<(QDataStream &out, const ChangeIdsCommand &command); -QDataStream &operator>>(QDataStream &in, ChangeIdsCommand &command); - -QDebug operator <<(QDebug debug, const ChangeIdsCommand &command); - } // namespace QmlDesigner Q_DECLARE_METATYPE(QmlDesigner::ChangeIdsCommand) diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/nodeinstanceserver.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/nodeinstanceserver.cpp index 2e7ac11f9d3..368f99a0331 100644 --- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/nodeinstanceserver.cpp +++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/nodeinstanceserver.cpp @@ -656,7 +656,7 @@ void NodeInstanceServer::changePropertyBindings(const ChangeBindingsCommand &com void NodeInstanceServer::changeIds(const ChangeIdsCommand &command) { - foreach (const IdContainer &container, command.ids()) { + for (const IdContainer &container : command.ids) { if (hasInstanceForId(container.instanceId())) instanceForId(container.instanceId()).setId(container.id()); } diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp index 2a2c7fce8fa..6b6cbefa5e5 100644 --- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp +++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp @@ -1261,8 +1261,7 @@ void Qt5InformationNodeInstanceServer::changeIds(const ChangeIdsCommand &command updateActiveSceneToEditView3D(); } else { qint32 sceneInstanceId = sceneInstance.instanceId(); - const QVector ids = command.ids(); - for (const auto &id : ids) { + for (const auto &id : command.ids) { if (sceneInstanceId == id.instanceId()) { QMetaObject::invokeMethod(m_editView3DRootItem, "handleActiveSceneIdChange", Qt::QueuedConnection, diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.cpp index 5b4e21d468a..a6570b4a1e9 100644 --- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.cpp +++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.cpp @@ -125,7 +125,7 @@ void Qt5TestNodeInstanceServer::changeAuxiliaryValues(const ChangeAuxiliaryComma void Qt5TestNodeInstanceServer::changeIds(const ChangeIdsCommand &command) { - foreach (const IdContainer &container, command.ids()) { + for (const IdContainer &container : command.ids) { if (hasInstanceForId(container.instanceId())) instanceForId(container.instanceId()).setId(container.id()); } diff --git a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp index 2b45e4c1bfe..ece4fa35b9c 100644 --- a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp +++ b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp @@ -1146,7 +1146,7 @@ ChangeBindingsCommand NodeInstanceView::createChangeBindingCommand(const QList &instanceList) const { QVector containerList; - foreach (const NodeInstance &instance, instanceList) { + for (const NodeInstance &instance : instanceList) { QString id = instance.modelNode().id(); if (!id.isEmpty()) { IdContainer container(instance.instanceId(), id); @@ -1154,7 +1154,7 @@ ChangeIdsCommand NodeInstanceView::createChangeIdsCommand(const QList