feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectNodes: Do not derive Project Nodes from QObject

Browse Source 
That should save some memory per node, and since creator has a lot of nodes
(e.g. opening the LLVM project adds about 1 000 000 nodes) this should be
noticeable:-)

Calling update inside ProjectTree::currentNode() and rename it to
findCurrentNode() to make sure it is an still existing pointer.
Also, try to reduce the somehow more expensive currentNode() calls
and sprinkle some const around that usage.

Change-Id: I6a7c5db01a71d53d39544d3013cad557d5b96cdc
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Tobias Hunger
2017-05-31 15:48:45 +02:00
committed by Tim Jenssen
parent bbb54cdeba
commit 45046f7071
25 changed files with 129 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmlprojectmanager/qmlprojectnodes.cpp
View File

@@ -57,13 +57,13 @@ bool QmlProjectNode::showInSimpleTree() const
return true;
}
bool QmlProjectNode::supportsAction(ProjectAction action, Node *node) const
bool QmlProjectNode::supportsAction(ProjectAction action, const Node *node) const
{
if (action == AddNewFile || action == EraseFile)
return true;
if (action == Rename && node->nodeType() == NodeType::File) {
FileNode *fileNode = static_cast<FileNode *>(node);
const FileNode *fileNode = dynamic_cast<const FileNode *>(node);
return fileNode->fileType() != FileType::Project;
}

2
src/plugins/qmlprojectmanager/qmlprojectnodes.h
View File

@@ -39,7 +39,7 @@ public:
QmlProjectNode(QmlProject *project);
bool showInSimpleTree() const override;
bool supportsAction(ProjectExplorer::ProjectAction action, Node *node) const override;
bool supportsAction(ProjectExplorer::ProjectAction action, const Node *node) const override;
bool addFiles(const QStringList &filePaths, QStringList *notAdded = 0) override;
bool deleteFiles(const QStringList &filePaths) override;
bool renameFile(const QString &filePath, const QString &newFilePath) override;