From 4539aa0c2b57880b831c28f4251f06477737e40c Mon Sep 17 00:00:00 2001
From: Fawzi Mohamed <fawzi.mohamed@digia.com>
Date: Mon, 4 Aug 2014 21:19:59 +0200
Subject: [PATCH] Ios: Fix version comparison

after an hint of CppCheck performed by Tobias Hunger

Change-Id: I5b2239faa4acf936389e1b4d1d7eb2acc3e7f3b3
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
---
 src/plugins/ios/iosprobe.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/plugins/ios/iosprobe.cpp b/src/plugins/ios/iosprobe.cpp
index 54c01975cd0..8cea854e15b 100644
--- a/src/plugins/ios/iosprobe.cpp
+++ b/src/plugins/ios/iosprobe.cpp
@@ -63,7 +63,7 @@ static int compareVersions(const QString &v1, const QString &v2)
     QStringList v1L = v1.split(QLatin1Char('.'));
     QStringList v2L = v2.split(QLatin1Char('.'));
     int i = 0;
-    while (v1.length() > i && v1.length() > i) {
+    while (v1L.length() > i && v2L.length() > i) {
         bool n1Ok, n2Ok;
         int n1 = v1L.value(i).toInt(&n1Ok);
         int n2 = v2L.value(i).toInt(&n2Ok);
@@ -77,9 +77,9 @@ static int compareVersions(const QString &v1, const QString &v2)
             return 1;
         ++i;
     }
-    if (v1.length() > v2.length())
+    if (v1L.length() > v2L.length())
         return -1;
-    if (v1.length() < v2.length())
+    if (v1L.length() < v2L.length())
         return 1;
     return 0;
 }