feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Analyzer: Base ISettingsAspect on Utils::AspectContainer

Browse Source 
Change-Id: Ib4c19d0cb167911dc50d989771dd53f3569db087
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2021-04-06 18:35:27 +02:00
parent 8eb74080ab
commit 454e8a31e2
10 changed files with 59 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/qmlprofiler/qmlprofilersettings.cpp
View File

@@ -57,9 +57,9 @@ QmlProfilerSettings::QmlProfilerSettings()
{
setConfigWidgetCreator([this] { return createQmlConfigWidget(this); });
group.setSettingsGroup(Constants::ANALYZER);
setSettingsGroup(Constants::ANALYZER);
group.registerAspect(&flushEnabled);
registerAspect(&flushEnabled);
flushEnabled.setSettingsKey("Analyzer.QmlProfiler.FlushEnabled");
flushEnabled.setLabelPlacement(BoolAspect::LabelPlacement::InExtraLabel);
flushEnabled.setLabelText(tr("Flush data while profiling:"));
@@ -68,17 +68,17 @@ QmlProfilerSettings::QmlProfilerSettings()
"data and the memory usage in the application. It distorts the profile as the flushing\n"
"itself takes time."));
group.registerAspect(&flushInterval);
registerAspect(&flushInterval);
flushInterval.setSettingsKey("Analyzer.QmlProfiler.FlushInterval");
flushInterval.setRange(1, 10000000);
flushInterval.setDefaultValue(1000);
flushInterval.setLabelText(tr("Flush interval (ms):", nullptr));
flushInterval.setEnabled(false); // Controled by flushEnabled.
group.registerAspect(&lastTraceFile);
registerAspect(&lastTraceFile);
lastTraceFile.setSettingsKey("Analyzer.QmlProfiler.LastTraceFile");
group.registerAspect(&aggregateTraces);
registerAspect(&aggregateTraces);
aggregateTraces.setSettingsKey("Analyzer.QmlProfiler.AggregateTraces");
aggregateTraces.setLabelPlacement(BoolAspect::LabelPlacement::InExtraLabel);
aggregateTraces.setLabelText(tr("Process data only when process ends:"));
@@ -94,25 +94,14 @@ QmlProfilerSettings::QmlProfilerSettings()
&flushInterval, &BaseAspect::setEnabled);
// Read stored values
group.readSettings(Core::ICore::settings());
readSettings(Core::ICore::settings());
}
void QmlProfilerSettings::writeGlobalSettings() const
{
group.writeSettings(Core::ICore::settings());
writeSettings(Core::ICore::settings());
}
void QmlProfilerSettings::toMap(QVariantMap &map) const
{
group.toMap(map);
}
void QmlProfilerSettings::fromMap(const QVariantMap &map)
{
group.fromMap(map);
}
// QmlProfilerOptionsPage
QmlProfilerOptionsPage::QmlProfilerOptionsPage()

6
src/plugins/qmlprofiler/qmlprofilersettings.h
View File

@@ -46,12 +46,6 @@ public:
Utils::IntegerAspect flushInterval;
Utils::StringAspect lastTraceFile;
Utils::BoolAspect aggregateTraces;
Utils::AspectContainer group;
protected:
void toMap(QVariantMap &map) const override;
void fromMap(const QVariantMap &map) override;
};
class QmlProfilerOptionsPage final : public Core::IOptionsPage