From 4564b2c36cd708d7123239d226a1fd02ece6e741 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Fri, 30 Apr 2021 08:06:46 +0200
Subject: [PATCH] Git: Avoid one use of SynchronousProcess

The synchronity was not used anyway.

Change-Id: I9e724d7c01e7e89c12954ac9e2b213c65302d942
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
---
 src/plugins/git/gerrit/gerritmodel.cpp | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/plugins/git/gerrit/gerritmodel.cpp b/src/plugins/git/gerrit/gerritmodel.cpp
index 9f3a1014b67..6f1e76f8453 100644
--- a/src/plugins/git/gerrit/gerritmodel.cpp
+++ b/src/plugins/git/gerrit/gerritmodel.cpp
@@ -31,7 +31,7 @@
 #include <vcsbase/vcsoutputwindow.h>
 
 #include <utils/algorithm.h>
-#include <utils/synchronousprocess.h>
+#include <utils/qtcprocess.h>
 
 #include <QJsonArray>
 #include <QJsonDocument>
@@ -225,7 +225,8 @@ QString GerritChange::fullTitle() const
 // In theory, querying uses a continuation/limit protocol, but we assume
 // we will never reach a limit with those queries.
 
-class QueryContext : public QObject {
+class QueryContext : public QObject
+{
     Q_OBJECT
 public:
     QueryContext(const QString &query,
@@ -249,7 +250,7 @@ private:
 
     void errorTermination(const QString &msg);
 
-    QProcess m_process;
+    Utils::QtcProcess m_process;
     QTimer m_timer;
     QString m_binary;
     QByteArray m_output;
@@ -322,7 +323,8 @@ void QueryContext::start()
     // Order: synchronous call to error handling if something goes wrong.
     VcsOutputWindow::appendCommand(m_process.workingDirectory(), {m_binary, m_arguments});
     m_timer.start();
-    m_process.start(m_binary, m_arguments);
+    m_process.setCommand({m_binary, m_arguments});
+    m_process.start();
     m_process.closeWriteChannel();
 }
 
@@ -337,7 +339,7 @@ void QueryContext::errorTermination(const QString &msg)
 
 void QueryContext::terminate()
 {
-    Utils::SynchronousProcess::stopProcess(m_process);
+    m_process.stopProcess();
 }
 
 void QueryContext::processError(QProcess::ProcessError e)