feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix possibly memory corruption

Browse Source 
text.toUtf8() create a temporary QByteArray object, which is then destroyed and
const char *utfString may be corrupted.

Change-Id: Icd6584675c0c6e25423d25129d3b6fc8b055ebf0
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
Aleksey Sidorov
2012-08-19 23:38:19 +04:00
committed by Eike Ziller
parent 647071d84b
commit 457c289100
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/coreplugin/progressmanager/progressmanager_mac.mm
View File

@@ -128,8 +128,7 @@ static ApplicationProgressView *sharedProgressView = nil;
void Core::Internal::ProgressManagerPrivate::setApplicationLabel(const QString &text) void Core::Internal::ProgressManagerPrivate::setApplicationLabel(const QString &text)
{ {
const char *utf8String = text.toUtf8().constData(); NSString *cocoaString = [[NSString alloc] initWithUTF8String:text.toUtf8().constData()];
NSString *cocoaString = [[NSString alloc] initWithUTF8String:utf8String];
[[NSApp dockTile] setBadgeLabel:cocoaString]; [[NSApp dockTile] setBadgeLabel:cocoaString];
[cocoaString release]; [cocoaString release];
} }